vpn_openvpn_client.php - Fields not hidden/processed correctly in chrome
In Chrome (Version 57.0.2987.133 (64-bit) Mac tested) when you edit an OpenVPN Client and switch to shared-key mode, when you deselect create a TLS key and paste an existing key there a new key is created anyway on save and overwrites what was pasted there. User must edit, paste key again, and save.
The Peer Certificate Authority field is visible with shared-key selected and hidden when SSL/TLS is selected.
That's all I saw. Might be more.
Also misbehaves in latest 2.4 snapshots.
Revised onchage handlers to obviate need for second click in Chrome on MacOS
#1 Updated by Jim Pingle 14 days ago
- Category set to OpenVPN
- Status changed from New to Feedback
- Assignee set to Jim Pingle
I can't reproduce this at all here.
On 2.3.x the CRL field shows when it shouldn't, but that has been fixed on 2.4.
If I uncheck the box to generate a new shared key and paste a key into the Shared Key box, it retains that key.
The only potential bug I see is when I switch to shared key, the old TLS key field is not hidden, but it should be. But the TLS key field is not the same as the Shared Key field. I pushed a fix for that just now in 8769058
#2 Updated by Chris Linstruth 13 days ago
Hmm. That's frustrating. I know what I saw. Tested multiple times.
Currently when I select SSL/TLS I get the shared key fields. When I select Shared Key I get TLS fields.
There is still something very wrong on Chrome on the Mac.
Actually, when I reduced the text size so I could see more of the page I see what it is doing. When I change the mode from SSL/TLS to Shared key, the fields don't actually change until I click the mode selector again. Same happens the other way. If that is not clear I took a quick screencast that is a little too large to post here just let me know.
That explains it. What was happening is we were changing to Shared Key and not noticing that the displayed fields were still for the TLS key and had not changed to the shared key, pasting into the TLS key field, and a new shared key was generated on save.