Project

General

Profile

Actions

Bug #7469

closed

local_sync_accounts() slowness can trigger GUI/XMLRPC failures with many accounts

Added by Jim Pingle over 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
High
Category:
User Manager / Privileges
Target version:
Start date:
04/12/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

When a firewall has many local accounts, the time it takes for local_sync_accounts() to finish grows large enough to trigger timeouts and other problems for XMLRPC.

Notably, in an HA cluster this becomes a burden because that function is called for each filter sync.

On stand-alone firewalls the function is only called during bootup, so it does not have quite the same impact in that scenario, though it still delays the boot process.

To illustrate the issue I made a playback script that calls local_sync_accounts() and nothing else:

: grep -c '<user>' /conf/config.xml 
44
: time pfSsh.php playback localsyncusers
1.379u 5.649s 1:17.53 9.0%    633+216k 0+16190io 0pf+0w

For 44 accounts this particular test firewall needed 1 min 17 seconds to complete the sync process. This could easily overrun PHP/XMLRPC timeouts depending on the speed of the firewall cpu/disks/etc.

We have at least one customer hitting the issue ( 16693 ), plus at least one user report ( https://forum.pfsense.org/index.php?topic=127546.0 )

Actions #1

Updated by Renato Botelho over 7 years ago

  • Target version changed from 2.4.0 to 2.4.1

Pushing to 2.4.1 because the whole function should be changed to be optimized

Actions #2

Updated by Jim Pingle about 7 years ago

  • Target version changed from 2.4.1 to 2.4.2

Moving target to 2.4.2 as we need 2.4.1 sooner than anticipated.

Actions #3

Updated by Renato Botelho almost 7 years ago

  • Target version changed from 2.4.2 to 2.4.3
Actions #4

Updated by Renato Botelho over 6 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Jim Pingle over 6 years ago

  • Status changed from Feedback to Assigned

Current code is better but is not putting the users back into matching order on both units. Renato is working on an improvement to preserve the order on all nodes.

Actions #6

Updated by Renato Botelho over 6 years ago

  • Status changed from Assigned to Feedback
Actions #7

Updated by Paighton Bisconer over 6 years ago

Tested on Current Base System 2.4.3.a.20180216.1415

Syncing 106 users and adding a 107th took maybe two seconds, new user was there when secondary users page was reloaded immediately after saving new user.

Actions #8

Updated by Renato Botelho over 6 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF