Project

General

Profile

Actions

Bug #7558

closed

l2tp configure kills and sleeps even if first time

Added by Jeremy C. Reed almost 5 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
L2TP
Target version:
Start date:
05/20/2017
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

vpn_l2tp_configure in /etc/inc/vpn.inc
has killbypid and sleep(8) even if starting it for first time.
I suggest it should check if file_exists() first.
Note that killbypid via sigkillbypid does check for that
but wrap both with it since the sleep(8) is done regardless.

(I noticed this while working on my book.
My list of bugs is at http://reedmedia.net/books/pfsense/bugs.html )

Actions #1

Updated by Jim Pingle over 2 years ago

  • Category changed from VPN (Multiple Types) to L2TP
Actions #3

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions #4

Updated by Viktor Gurov about 2 years ago

  • Status changed from Pull Request Review to Resolved

works as expected on 2.5.0.a.20200409.0657

Actions

Also available in: Atom PDF