Project

General

Profile

Actions

Todo #7576

closed

invalid sysctl tunables

Added by Jeremy C. Reed almost 7 years ago. Updated almost 7 years ago.

Status:
Needs Patch
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
05/20/2017
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

system_advanced_sysctl.php allows adding a tunable with
a bogus name (like a space in it or doesn't exist) or bogus value.

Maybe report sysctl output?

Actions #1

Updated by Jim Pingle almost 7 years ago

  • Status changed from New to Needs Patch

I'm not certain there is a good way to do this in a way that wouldn't break other, valid behavior. Working with sysctls that get renamed makes this fuzzy, for example, kern.ipc.somaxconn can still be used in some cases to write a value even though the OID was renamed to kern.ipc.soacceptqueue, but it does not show up in sysctl -a output using the old name, just the new name. In that case it's best to move the value to the new name, but the old name still does work, just not in an ideal way.

Rejecting these could also prevent a user from staging tunable settings for new hardware before making a physical change. The tunables wouldn't be present because the hardware isn't there yet.

Maybe we could warn the user but I wouldn't go so far as to prevent such OIDs from being added.

Actions

Also available in: Atom PDF