Bug #7795
closed
NTP status widget: d.getSeconds is not a function
100%
Description
Already mentioned in #7784 but creating a separate bug for this.
When you select either the tunnels or the mobile tab on the IPsec widget, the browser console immediately gets spammed with Uncaught TypeError: d.getSeconds is not a function - error logged every second. Traced it to the NTP widget [1], apparently there's some weird interaction between the two widgets.
P.S. Same problem with 2.3.4-p1.
Updated by Anonymous about 7 years ago
- Assignee set to Anonymous
Looks like both widgets have a global var called "d". I bet they are stepping on each other. Would have been a good idea to use a widget-name-based prefix with all globals, like ntp_d, ipsec_d etc.
Renaming the var in the NTP widget seems to have fixed the issue.
Updated by Anonymous about 7 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 3ed475b11dfcb2999a71195987495ccf05808127.
Updated by Anonymous about 7 years ago
- % Done changed from 0 to 100
Applied in changeset da058fe4c156e607227f1bac03a3ade42c475115.
Updated by Kill Bill about 7 years ago
Steve Beaver wrote:
Looks like both widgets have a global var called "d". I bet they are stepping on each other.
Good catch. The fix works, thanks.
Updated by Jim Pingle about 7 years ago
- Target version changed from 2.4.1 to 2.4.0