Project

General

Profile

Bug #8054

DHCP server accepts trailing dot in domain names, DNS resolver adds another and breaks

Added by Jove Too over 2 years ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
DNS Resolver
Target version:
Start date:
11/04/2017
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.1
Affected Architecture:
amd64

Description

If you add a trailing dot on the domain name in the "domain name" and "domain search list", this is accepted. The DNS Resolver retrieves this domain name from a lease and adds a dot: the configuration file ends up with 2 trailing dots and unbound fails to parse its config file.

I believe adding the trailing dot in the domain name of the dhcp server is allowed but the DNS resolver should detect this trailing dot and not add a second one.

Associated revisions

Revision 8ee5aa03 (diff)
Added by Viktor Gurov 3 months ago

DHCP Domain trailing dot validation. Issue #8054

Revision 4b08280f (diff)
Added by Viktor Gurov 2 months ago

DHCP Domain trailing dot validation. Issue #8054

(cherry picked from commit 8ee5aa03950902e8de301dedaa1fddda4a74e709)

History

#1 Updated by Jove Too over 2 years ago

To be clear: this happened with a static lease.

#2 Updated by Viktor Gurov 3 months ago

This is true only for the DHCP static mapping "domain name" or the System / General / Domain, but not for the "domain search list".

Fix:
https://github.com/pfsense/pfsense/pull/4251

#3 Updated by Jim Pingle 3 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#4 Updated by Renato Botelho 3 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#5 Updated by Viktor Gurov 3 months ago

  • Status changed from Feedback to Resolved

works as expected on 2.5.0.a.20200403.1936

#6 Updated by Jim Pingle 2 months ago

  • Status changed from Resolved to Feedback
  • Target version changed from 2.5.0 to 2.4.5-p1

#7 Updated by Jim Pingle about 2 months ago

  • Status changed from Feedback to Resolved

The trailing dot is no longer allowed in input on the fields in question which would result in an error.

Also available in: Atom PDF