Project

General

Profile

Bug #8106

dhcp6c lock files not removed after unclean shutdown when using "Do not wait for an RA" on IPv6 WAN interface

Added by J L 11 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
DHCP6
Target version:
Start date:
11/18/2017
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.x
Affected Architecture:
All

Description

When using a WAN connection with IPv6 that requires the "Do not wait for an RA" option if the router has an unclean shutdown and reboot (power outage) the dhcp6c_$interface_lock file(s) will still be in /tmp, meaning that dhcp6c will not start leaving the IPv6 interface(s) in limbo. (In this state I've had the WAN interface get a local-link address and the IPv6 gateway would be "pending", or sometimes with 100% packet loss).

I've attached a patch to rc.bootup that before the interfaces are set up it iterates over interfaces in $config that use DHCP6, and if a lock file is present in /tmp it removes the file. This solves the issue in my extensive testing last night.

I've gotten Martin to review the patch and implemented some suggestions of his.

This patch applies cleanly to 2.4.0-RELEASE, 2.4.2-RC, and 2.4.3.a.20171117.1226 in my testing.

rc.bootup.patch (746 Bytes) rc.bootup.patch J L, 11/18/2017 02:43 PM

History

#1 Updated by Martin Wasley 11 months ago

Just do a PR on it Luke, it'll get reviewed there as part of the process.

#2 Updated by J L 11 months ago

Martin Wasley wrote:

Just do a PR on it Luke, it'll get reviewed there as part of the process.

Done: https://github.com/pfsense/pfsense/pull/3870

#3 Updated by Jim Thompson 11 months ago

  • Category set to DHCP6
  • Assignee set to Steve Beaver
  • Target version set to 2.4.3
  • Affected Architecture set to All

#4 Updated by J L 11 months ago

J L wrote:

Martin Wasley wrote:

Just do a PR on it Luke, it'll get reviewed there as part of the process.

Done: https://github.com/pfsense/pfsense/pull/3870

Said PR has been merged now.

#5 Updated by Jim Pingle 10 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#6 Updated by Jim Pingle 7 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF