Project

General

Profile

Bug #847

Deleting interface leaves remnant in interface groups

Added by David Szpunar almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Interfaces
Target version:
Start date:
08/25/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

Beta4 snapshot from Tue Aug 24 01:26:38 EDT 2010, deleting an interface (OPT5 in my case) that was a member of interface groups (3 of the four IGs I have) leaves "opt5" (lowercase) displaying in the group(s) it was a member of on the IG overview page. When I click Edit on one of the groups, however, OPT5 does not appear in the list of interfaces in the group, and if I Save without making any changes, the "opt5" disappears from the list of interfaces in that group.

Associated revisions

Revision 48f23632 (diff)
Added by Ermal Luçi almost 9 years ago

Fixes #847. Check even interface groups before allowing deletion of an interface. Also try to readd to a group an interface when configuring.

Revision 1dbc0c43 (diff)
Added by Ermal Luçi over 8 years ago

Use correct variable name. Also related to Ticket #847.

History

#1 Updated by Ermal Luçi almost 9 years ago

  • Status changed from New to Feedback

#2 Updated by Ermal Luçi almost 9 years ago

  • % Done changed from 0 to 100

#3 Updated by David Szpunar over 8 years ago

This bug still exists, I just tested it on the most recent snapshot from this afternoon. I created an interface (opt10), assigned it a static IP, created an Interface Group and added it and another already-existing interface to the group. Then I deleted the opt10 interface. When I viewed the Interface Groups page, it still shows "opt10" in the list of interfaces in the group I had created (using the lowercase actual name, opt10, not the display name I'd set for the interface originally). When I clicked Edit on the group, it showed the still-existing interface (correctly), and a second interface (WAN in this case) which was never a part of the group selected as the second interface of the group (opt10 was no where to be found at this point).

My expectation of the UI is that when I delete an interface, it will no longer show up as a member of the interface group it was a member of before I deleted it.

#4 Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to New

It either:
1) shouldn't allow deleting an interface that's in an interface group
or
2) should automatically remove that interface from the group if it's deleted.

#5 Updated by Ermal Luçi over 8 years ago

  • Status changed from New to Feedback

Well this is indirectly resolved by the latest commit(referenced to this issue to).
link_interface_to_group() function was not reporting correctly so you were able to delete teh interface.

Normally you are not able because it will not allow you to delete an interface that is part of a group.

I am not sure if things like this should be hard checked at boot time for consistency.

#6 Updated by Ermal Luçi over 8 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF