Project

General

Profile

Bug #8683

Unable to add GIF interface (Hurricane Electric IPv6)

Added by P Law 7 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Gateways
Target version:
Start date:
07/23/2018
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.4.4
Affected Architecture:
All

Description

From crash report:

[23-Jul-2018 22:38:59 America/New_York] PHP Warning: exec(): NULL byte detected. Possible attack in /etc/inc/util.inc on line 1712
[23-Jul-2018 22:38:59 America/New_York] PHP Warning: exec(): NULL byte detected. Possible attack in /etc/inc/util.inc on line 1712
[23-Jul-2018 22:38:59 America/New_York] PHP Warning: file_put_contents() expects parameter 1 to be a valid path, string given in /etc/inc/interfaces.inc on line 1200

From logs:

/interfaces_gif_edit.php: XML error: Invalid character at line 13772 in /conf/config.xml

History

#1 Updated by Jim Pingle 7 months ago

  • Status changed from New to Assigned
  • Assignee set to Jim Pingle
  • Target version set to 2.4.4

#2 Updated by Jim Pingle 7 months ago

  • Assignee changed from Jim Pingle to Renato Botelho

This appears to be caused by the interface string returned by pfSense_interface_create() which is not a string in the expected format.

config.xml.bad:4681: parser error : Char 0x0 out of allowed range
            <gifif>gif1
                       ^
config.xml.bad:4681: parser error : Premature end of data in tag gifif line 4681
            <gifif>gif1
                       ^
config.xml.bad:4681: parser error : Premature end of data in tag gif line 4673
            <gifif>gif1
                       ^
config.xml.bad:4681: parser error : Premature end of data in tag gifs line 4672
            <gifif>gif1
                       ^
config.xml.bad:4681: parser error : Premature end of data in tag pfsense line 2
            <gifif>gif1
                       ^
var_dump( pfSense_interface_create("gif") );
var_dump( "gif4" );

Outputs:
string(15) "gif4" 
string(4) "gif4" 

#3 Updated by Jim Pingle 6 months ago

This also affects GRE interfaces

#4 Updated by Jim Pingle 6 months ago

  • Status changed from Assigned to This Sprint

#5 Updated by Renato Botelho 6 months ago

  • Assignee changed from Renato Botelho to Steve Beaver

Steve is working on this one

#6 Updated by Steve Beaver 6 months ago

  • Status changed from This Sprint to Feedback

#7 Updated by Steve Beaver 6 months ago

var_dump( pfSense_interface_create("gif"));

Now produces:
string(4) "gif0"

#8 Updated by Jim Pingle 6 months ago

Result for gre also looks good.

#9 Updated by Anonymous 6 months ago

  • Status changed from Feedback to Resolved

Tested on 2.4.4-DEVELOPMENT (amd64)
built on Tue Aug 28 08:43:43 EDT 2018
FreeBSD 11.2-RELEASE-p2

Was able to create/edit/delete a GIF interface with no seen errors.

Also available in: Atom PDF