Project

General

Profile

Bug #8767

ID handling problem with DNS Forwarder host override management

Added by Jim Pingle 12 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
DNS Forwarder
Target version:
Start date:
08/07/2018
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.x
Affected Architecture:
All

Description

When editing or deleting DNS Forwarder host entries, occasionally the ID numbers can get out of alignment, leading to making changes on the wrong item.

Fixed by PR https://github.com/pfsense/pfsense/pull/3966 which was merged a couple weeks ago

Associated revisions

Revision bc91bdff (diff)
Added by Stephen Jones 11 months ago

Fixes #8767 PHP7 syntax error

History

#1 Updated by Vladimir Lind 11 months ago

On 2.4.4 Fri Aug 17 21:29:09 EDT 2018

When testing host edit/delete actions with host overrides in dns forwarder was catching php warning when opening host entry to edit:

Warning: Illegal string offset 'item' in /usr/local/www/services_dnsmasq_edit.php on line 244 Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/www/services_dnsmasq_edit.php on line 249 Warning: Invalid argument supplied for foreach() in /usr/local/www/services_dnsmasq_edit.php on line 251

#2 Updated by Azamat Khakimyanov 11 months ago

I tried to reproduce this issue on 2.4.2:
- I added more then 120 DNS Forwarder host overrides
- I didn't see issue when I pressed Edit button
- but I did see issue when I deleted one of the host override. But it only happens when you try to delete just after you've added more then 1 host override.

I wasn't able to reproduce this issue on 2.4.3_p1 and on 2.4.4.a.20180826.1232.

#3 Updated by Anonymous 11 months ago

Fixed the illegal string offset error described above. bc91bdffcefd009f4716cce59eab231c2245fb18

I did not notice any errors with the IDs while testing this.

2.4.4-DEVELOPMENT (amd64) 
built on Wed Aug 29 00:38:57 EDT 2018
FreeBSD 11.2-RELEASE-p2

#4 Updated by Anonymous 11 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF