Project

General

Profile

Actions

Feature #8878

closed

Propagate user's description field into QR code for FreeRADIUS

Added by Juraj Lutter almost 4 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
FreeRADIUS
Target version:
-
Start date:
09/06/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:

Description

Hi,

it is often desirable (esp. when you have more than one identity added in your Google Auth mobile app) to distinguish between different identities. Having all of them to be descripted as "*FreeRADIUS*" is not the most convenient way.

I have made the following modification to freeradius.xml:

-                                                var provider = encodeURIComponent("FreeRADIUS");
+                                                var provider = encodeURIComponent($('#description').val());
+                                                if (provider.length == 0) {
+                                                   provider = encodeURIComponent("FreeRADIUS");
+                                                }

What do you think about it?

Actions #1

Updated by Jim Pingle almost 3 years ago

  • Project changed from pfSense to pfSense Packages
  • Category set to FreeRADIUS
Actions #2

Updated by Juraj Lutter almost 3 years ago

Looks good to me.

Actions #3

Updated by Juraj Lutter almost 3 years ago

Juraj Lutter wrote:

Hi,

it is often desirable (esp. when you have more than one identity added in your Google Auth mobile app) to distinguish between different identities. Having all of them to be descripted as "*FreeRADIUS*" is not the most convenient way.

I have made the following modification to freeradius.xml:

[...]

What do you think about it?

Looks good to me. Thanks.

Actions #5

Updated by Jim Pingle over 2 years ago

  • Status changed from New to Pull Request Review
Actions #6

Updated by Renato Botelho over 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #7

Updated by Viktor Gurov over 2 years ago

  • Status changed from Feedback to Resolved

works as expected on pfSense 2.4.5 with freeradius3 0.15.7_11

Actions

Also available in: Atom PDF