Project

General

Profile

Actions
Copy link

Bug #8880

closed
CK

[PHP7] warning on system_gateways.php and extra item in gateways table

Bug #8880: [PHP7] warning on system_gateways.php and extra item in gateways table

Added by Constantine Kormashev about 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
PHP Interpreter
Target version:
2.4.4
Start date:
09/10/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

244-RC

FreeBSD pf5100v.lab 11.2-RELEASE-p2 FreeBSD 11.2-RELEASE-p2 #1 d792717682e(factory-RELENG_2_4_4): Thu Sep  6 00:07:43 EDT 2018     root@buildbot3:/crossbuild/244/obj/amd64/as0Ifpf7/crossbuild/244/pfSense/tmp/FreeBSD-src/sys/pfSense  amd64

I got a php warning after deleting gateway group and switching to gateways

Warning: Illegal string offset 'inactive' in /etc/inc/gwlb.inc on line 601
Warning: Illegal string offset 'monitor' in /etc/inc/gwlb.inc on line 646
Warning: Illegal string offset 'friendlyiface' in /etc/inc/gwlb.inc on line 653
Warning: Illegal string offset 'interface' in /etc/inc/gwlb.inc on line 659
Warning: Cannot assign an empty string to a string offset in /etc/inc/gwlb.inc on line 659
Warning: Illegal string offset 'attribute' in /etc/inc/gwlb.inc on line 672

Also I can see extra object 0

There is difference between old and current config:

--- /conf/backup/config-1536577702.xml    2018-09-10 14:08:31.633812000 +0300
+++ /conf/config.xml    2018-09-10 14:08:31.646044000 +0300
@@ -1947,8 +1947,8 @@
         </domainoverrides>
     </unbound>
     <revision>
-        <time>1536577702</time>
-        <description><![CDATA[admin@192.168.129.2 (Local Database): System - Gateways: save default gateway]]></description>
+        <time>1536577711</time>
+        <description><![CDATA[admin@192.168.129.2 (Local Database): Gateway Groups: removed gateway group 0]]></description>
         <username>admin@192.168.129.2 (Local Database)</username>
     </revision>
     <cert>
@@ -2261,15 +2261,9 @@
         </ppp>
     </ppps>
     <gateways>
-        <gateway_group>
-            <name>GWGR</name>
-            <item>LAN_DHCP|1|address</item>
-            <item>WAN_DHCP|1|address</item>
-            <trigger>down</trigger>
-            <descr></descr>
-        </gateway_group>
         <defaultgw4>WAN_DHCP</defaultgw4>
         <defaultgw6>-</defaultgw6>
+        <gateway_item></gateway_item>
     </gateways>
     <dnsupdates>
         <dnsupdate>

Files

err.png (209 KB) err.png Constantine Kormashev, 09/10/2018 06:14 AM

CK Updated by Constantine Kormashev about 8 years ago Actions
Copy link
 #1

Updated by Anonymous about 8 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • Assignee set to Anonymous
  • Target version set to 2.4.4

Updated by Anonymous about 8 years ago Actions
Copy link
 #3

  • % Done changed from 0 to 100

Applied in changeset commit:a155dc5ec2278e0a344afa221127b8503d4e225e.

JP Updated by Jim Pingle about 8 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Resolved

Blank entries are not displayed on current RC snap and they do not cause PHP errors.

CK Updated by Constantine Kormashev almost 8 years ago Actions
Copy link
 #5

  • Status changed from Resolved to Assigned

Latest 14 Sep RC snapshot does not contain commit a155dc5ec2278e0a344afa221127b8503d4e225e with this patch. But issue was solved by applying patch manually.

CK Updated by Constantine Kormashev almost 8 years ago Actions
Copy link
 #6

  • Status changed from Assigned to Resolved

CK Updated by Constantine Kormashev almost 8 years ago Actions
Copy link
 #7

  • Status changed from Resolved to Feedback

Keep it open until checking on next build, which contains current patch.

RB Updated by Renato Botelho almost 8 years ago Actions
Copy link
 #8

This commit was not cherry-picked from master branch. Can you validate the fix on a 2.4.5 snapshot? I did the cherry-pick now and it will be available when we do another RC

CK Updated by Constantine Kormashev almost 8 years ago Actions
Copy link
 #9

I've checked on 245, it works, I do not observe extra GW 0 and php warning:

2.4.5-DEVELOPMENT (amd64)
built on Mon Sep 17 16:21:24 EDT 2018
FreeBSD 11.2-RELEASE-p3

RB Updated by Renato Botelho almost 8 years ago Actions
Copy link
 #10

  • Status changed from Feedback to Resolved

CK Updated by Constantine Kormashev almost 8 years ago Actions
Copy link
 #11

Just in case. So not see the issue on latest

2.4.4-RELEASE (amd64)
built on Thu Sep 20 09:33:19 EDT 2018
FreeBSD 11.2-RELEASE-p3

Actions
Copy link

Also available in: Atom