Project

General

Profile

Bug #900

OpenVPN Wizard: Server Certificate Wizard

Added by Ricardo Ramirez R. over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
OpenVPN
Target version:
Start date:
09/16/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

Creating a Server Certificate with Wizard

2.0-BETA4 (i386)
built on Wed Sep 15 09:52:13 EDT 2010
FreeBSD 8.1-RELEASE

Intel(R) Pentium(R) D CPU 3.00GHz

OpenVPN_Wizard__Server_Certificate_Selection.png (33.2 KB) OpenVPN_Wizard__Server_Certificate_Selection.png Wizard screenshot Ricardo Ramirez R., 09/16/2010 11:25 PM

Associated revisions

Revision e4d7a064 (diff)
Added by jim-p over 8 years ago

Prevent a foreach on what might not be an array. Fixes #900

Revision 8f87a4a2 (diff)
Added by Jim Pingle over 8 years ago

Reject special characters in CA/Cert field names during OpenVPN wizard. Fixes #900

History

#1 Updated by Jim Pingle over 8 years ago

  • Tracker changed from Todo to Bug

Did you leave some fields blank when creating the certificate?

I added a check that will prevent a foreach on an empty item, but something that shouldn't be empty had to be empty for that to happen.

#2 Updated by Anonymous over 8 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Ricardo Ramirez R. over 8 years ago

May be is an accent in the city, I wrote Toncancip√°

#4 Updated by Jim Pingle over 8 years ago

That is possible. I do not believe that extended characters are supported in openssl certificates very well (or at least they used to not be, that may have improved over the years)

The input validation should probably kick those back as invalid input for now.

#5 Updated by Ricardo Ramirez R. over 8 years ago

Ok. It worked without accents.

Thank you very much!

#7 Updated by Jim Pingle over 8 years ago

  • Status changed from Feedback to New

Spoke too soon. It prints the error message properly but the bad values are still saved in the config and a config restore is triggered on save.

#8 Updated by Jim Pingle over 8 years ago

  • Status changed from New to Feedback

It should be fixed now after my latest commits (not seen on this ticket). Some changes to wizard.php were needed to prevent the bad values from saving.

#9 Updated by Jon Gerdes over 8 years ago

I created a new server cert using wizard. It refused to allow me to continue unless all fields were filled in. I also tried to use some fancy chars and this too was caught and a sensible error message displayed. I checked the config file and that seems correct to me

#10 Updated by Jim Pingle over 8 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF