Project

General

Profile

Feature #9003

Add 'Copy Running to Saved' option to the raw config

Added by Ben Hughes almost 2 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
FRR
Target version:
-
Start date:
10/04/2018
Due date:
% Done:

100%

Estimated time:

Description

Would be possible to add these buttons to the raw config page as the Quagga package does, i'm slowly moving over to using FRR over Quagga for the new features being added but having to cat the /var/etc/frr/*.conf file and paste is into the UI for each daemon can be error prone.

As an improvement over the quagga a 'copy all' button would be excellent.

History

#1 Updated by Viktor Gurov 5 months ago

I do not understand why quagga-way (saving configuration in base64 format in config.xml) may be error prone.
Both *.conf and config.xml contains same data.
This is the port from Quagga with a 'copy all' button:
https://github.com/pfsense/FreeBSD-ports/pull/777

#2 Updated by Jim Pingle 5 months ago

  • Status changed from New to Pull Request Review

#3 Updated by Ben Hughes 5 months ago

Viktor Gurov wrote:

I do not understand why quagga-way (saving configuration in base64 format in config.xml) may be error prone.
Both *.conf and config.xml contains same data.
This is the port from Quagga with a 'copy all' button:
https://github.com/pfsense/FreeBSD-ports/pull/777

The error prone part is that the feature isn't/wasn't available so you had to SSH in and manually copy the file contents, that was the error prone part. The same function as quagga would fix it.

#4 Updated by Renato Botelho 4 months ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#5 Updated by Viktor Gurov 3 months ago

Renato Botelho wrote:

PR has been merged. Thanks!

js function configCheck() is does not exist
This PR adds it and fixes other js code for 'copy running to saved' function:
https://github.com/pfsense/FreeBSD-ports/pull/846

#6 Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Pull Request Review

#7 Updated by Renato Botelho 3 months ago

  • Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

#8 Updated by Viktor Gurov 3 months ago

  • Status changed from Feedback to Resolved

now it works as expected on FRR 0.6.4_4

Also available in: Atom PDF