Project

General

Profile

Bug #9042

Web GUI does not recognise NVMe devices as SMART capable

Added by Steve Wheeler over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
S.M.A.R.T.
Target version:
Start date:
10/14/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.4.x
Affected Architecture:
All

Description

It looks like it's only looking for ad, ada or da devices:
https://github.com/pfsense/pfsense/blob/c0787ee92aeaa51cee0c03806405cfe8790ec2ca/src/etc/inc/util.inc#L2605

Though smartctl sees nvme devices and can read them correctly.

See: https://forum.netgate.com/topic/136685/2-4-4-smart-nvme-drive-detection-seems-to-fail

Associated revisions

Revision 5ae720be (diff)
Added by Jim Pingle over 2 years ago

Show nvme devices in SMART disk list. Fixes #9042

(cherry picked from commit 89b4d4f30576908e36d5c6b70701db2f5e7363e6)

Revision bdb6021f (diff)
Added by Jim Pingle over 2 years ago

Show nvme devices in SMART disk list. Fixes #9042

Revision dba7debb (diff)
Added by Jim Pingle over 2 years ago

Revert "Show nvme devices in SMART disk list. Fixes #9042"

This reverts commit bdb6021f79f222b2c7d732436800e96cb34ea973.

Revision 083e4291 (diff)
Added by Jim Pingle over 2 years ago

Revert "Show nvme devices in SMART disk list. Fixes #9042"

This reverts commit bdb6021f79f222b2c7d732436800e96cb34ea973.

(cherry picked from commit dba7debb2e6be1ef469d99fa5e9673fba3f7d6db)

Revision e738a4c9 (diff)
Added by Jim Pingle over 2 years ago

Show nvme controllers in SMART list. Fixes #9042

Revision 82c85c97 (diff)
Added by Jim Pingle over 2 years ago

Show nvme controllers in SMART list. Fixes #9042

(cherry picked from commit e738a4c9b2607ad3561a0fce89d903535ca71249)

History

#1 Updated by Jim Pingle over 2 years ago

  • Assignee set to Jim Pingle
  • Target version set to 2.4.4-p1

This should be a one-line fix but I had a follow-up question about the devices (nvd vs nvme) since their examples were not consistent, which I posted in the forum thread.

#2 Updated by Jim Pingle over 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle over 2 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF