Project

General

Profile

Bug #9384

devd putting "$" before variable contents when using single quotes

Added by Jim Pingle over 1 year ago. Updated 6 days ago.

Status:
Confirmed
Priority:
Normal
Category:
Interfaces
Target version:
Start date:
03/06/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.5.0
Affected Architecture:
All

Description

On 2.5.0 snapshots, when check_reload_status logs a linkup event, the message contains a $ before the interface name that does not appear to be necessary/relevant:

Mar 6 14:17:25     check_reload_status     357     Linkup starting $vmx1
Mar 6 14:17:25     check_reload_status     357     Linkup starting $vmx2
Mar 6 14:17:28     check_reload_status     357     Linkup starting $vmx3

Associated revisions

Revision de9df940 (diff)
Added by Jim Pingle about 1 year ago

Trim bonus '$' added by devd bug. Works around issue #9384

Revision fbb49296 (diff)
Added by Renato Botelho 20 days ago

Fix #9384

As mentioned by Warner Losh <>, author of the change on
FreeBSD, the correct way to use quotes to parameters containing
variables is:

cmd param1 'param2 contain spaces and '$variables

Replace all actions on our devd.conf following this recommendations

History

#1 Updated by Jim Pingle over 1 year ago

This also appears to affect rc.carpmaster (and rc.carpbackup), which is also run through pfSctl

Mar 15 11:34:23     php-fpm     321     /rc.carpmaster: HA cluster member "(2001:db8::11:11@vmx0): (WAN)" has resumed CARP state "MASTER" for vhid $11
Mar 15 11:34:24     php-fpm     321     /rc.carpmaster: HA cluster member "(2001:db8::11:11@vmx0): (WAN)" has resumed CARP state "MASTER" for vhid $15 

Also, not sure if it's related but the IP address printed for the VHID 11 line is incorrect.

    inet6 2001:db8::12 prefixlen 64 
    inet6 2001:db8::11 prefixlen 64 vhid 15 
    inet6 2001:db8::11:11 prefixlen 64 vhid 15 
    inet 198.51.100.12 netmask 0xffffff00 broadcast 198.51.100.255 
    inet 198.51.100.11 netmask 0xffffff00 broadcast 198.51.100.255 vhid 11 
    carp: MASTER vhid 11 advbase 1 advskew 0
    carp: MASTER vhid 15 advbase 1 advskew 0

#2 Updated by Jim Pingle about 1 year ago

  • Subject changed from check_reload_status linkup log message has a "$" before the interface name to devd putting "$" before variable contents when using single quotes

Adjusted title. This is a devd issue, not anything wrong with check_reload_status. Also affects other systems like OpenVPN not starting on CARP VIPs, and probably anything else touched by devd.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240411

#3 Updated by Renato Botelho about 1 year ago

  • Assignee set to Renato Botelho

#4 Updated by Renato Botelho 23 days ago

  • Assignee changed from Renato Botelho to Mark Johnston

Mark told me he would take a look at upstream regression

#5 Updated by Renato Botelho 20 days ago

  • Status changed from New to In Progress
  • Assignee changed from Mark Johnston to Renato Botelho

I'll fix it as suggested by imp@

#6 Updated by Renato Botelho 20 days ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

#7 Updated by Renato Botelho 20 days ago

  • Status changed from Feedback to In Progress

Problem still happens

#8 Updated by Renato Botelho 6 days ago

  • Status changed from In Progress to Confirmed
  • Target version changed from 2.5.0 to 2.5.next

Pingle's workaround is enough for now. Move ticket to next release and wait a proper fix from upstream

Also available in: Atom PDF