Project

General

Profile

Actions

Feature #9523

closed

LADVD: Feature to enable setting interface descriptions

Added by Jason Unovitch almost 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Low
Category:
ladvd
Target version:
-
Start date:
05/12/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:

Description

Good day. I'd be interested in seeing options for the -y and -z flag to LADVD get added.

These are explain in ladvd(8).

-y Save received peer hostname and port description in interface
descriptions (requires SIOCSIFDESCR support) or Linux ifAliases.
This also enables receive mode.

-z Save received peer hostname and port name in interface
descriptions (requires SIOCSIFDESCR support) or Linux ifAliases.
This also enables receive mode.

The result, of -z in this case is shown like so:

igb0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
    description: connected to UBNT (0/1)
    options=400b8<VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,VLAN_HWTSO>

Patch attached as an example. The options aren't mutually exclusive however it does seem to default on the first specified. So perhaps a select one or the other drop box would be better.

The text shown also a bit wordy so could use a suggestion over what would be most ideal as far as both the options and config option naming.

Cheers,
Jason


Files

pfsense-ladvd-description.diff (1.54 KB) pfsense-ladvd-description.diff Jason Unovitch, 05/12/2019 10:18 AM
Actions #1

Updated by Jason Unovitch almost 5 years ago

Looking at FreeNAS, they've got a much more succinct description and only added support for the -z option, which seems more useful as the port description lists things like "Intel PRO/1000 ..." depending on what it goes to.

Ref 1: https://www.ixsystems.com/documentation/freenas/11.2-U4.1/services.html#lldp
Ref 2: https://redmine.ixsystems.com/issues/4208

Actions #3

Updated by Jim Pingle about 4 years ago

  • Status changed from New to Pull Request Review
Actions #4

Updated by Renato Botelho about 4 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Viktor Gurov about 4 years ago

  • Status changed from Feedback to Resolved

Renato Botelho wrote:

PR has been merged. Thanks!

tested on pfSense 2.5.0.a.20200103.2159 with LADVD 1.2.2_1

works as expected

Actions

Also available in: Atom PDF