Project

General

Profile

Actions

Feature #9693

closed

Bypass automatic backups

Added by Anonymous over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Backup / Restore
Target version:
Start date:
08/21/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:

Description

If the reason/description string of a config back contains the string "-NoReMoTeBaCkUp" no ACB will be performed. The string is removed before the local config file is changed.

This is to allow packages such as Snort and pfBlockerNG to write to config.xml without hammering the ACB system.

E.g.:

   write_config("Just making a little change-NoReMoTeBaCkUp");

Will cause the configuration change description "Just making a little change" to be recorded. NO ACB will be performed.

Actions #1

Updated by Anonymous over 4 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Anonymous over 4 years ago

  • Status changed from Feedback to Resolved

Tested on 2.5.0.a.20190830.1941, works as expected.

Actions #3

Updated by Gerwim F over 4 years ago

James Dekker wrote:

Tested on 2.5.0.a.20190830.1941, works as expected.

There's a typo on line 190 (in src/etc/inc/acb.inc):

function upload_config($manual = flase) {

flase should be false

Actions #4

Updated by Jim Pingle over 4 years ago

  • Status changed from Resolved to New
Actions #5

Updated by Anonymous over 4 years ago

  • Status changed from New to Closed

This was fixed moments after the original push

Actions #6

Updated by Jim Pingle over 4 years ago

  • Target version changed from 2.5.0 to 2.4.5
Actions #7

Updated by Jim Pingle over 4 years ago

  • Status changed from Closed to Feedback

Needs checked and/or tested again on 2.4.5 snapshots

Actions #8

Updated by Jim Pingle over 4 years ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Anonymous to Jim Pingle

Manual backups with a reason entered by the user aren't getting the correct string appended, so MaNuAlBaCkUp is showing through in the backup list when it shouldn't be. It's an easy fix, I'll take care of it.

Actions #9

Updated by Jim Pingle over 4 years ago

  • Status changed from In Progress to Feedback
  • Assignee changed from Jim Pingle to Anonymous

Cherry picked 0bdd1774a1666852e35452ea3f17bb9dc075ecec which fixed it on master.

I tested the NoReMoTeBaCkUp string as well and it behaved as expected.

Actions #10

Updated by Jim Pingle over 4 years ago

  • Status changed from Feedback to Resolved

Looks good now.

Actions

Also available in: Atom PDF