Project

General

Profile

Actions
Copy link

Bug #9741

closed

interfaces_ppps_edit.php: WebGUI don't show local ip / gateway ip values

Added by Viktor Gurov about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
PPP Interfaces
Target version:
2.4.5
Start date:
09/10/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.5.0
Affected Architecture:
All

Description

After adding L2TP / PPTP interfaces on Interfaces / PPPs pages
it add Local IP Address and Gateway IP or Hostname to config.xml
but don't show it if you press edit icon of interface

<ppp>
<ptpid>0</ptpid>
<type>l2tp</type>
<if>l2tp0</if>
<ports>vtnet1</ports>
<username>user1</username>
<password>MTIz</password>
<descr><![CDATA[2123312]]></descr>
<localip>1.2.3.4</localip>
<subnet>31</subnet>
<gateway>10.1.0.5</gateway>
<bandwidth></bandwidth>
<mtu></mtu>
<mru></mru>
<mrru></mrru>
</ppp>

issue on 2.4.4-p3
and
2.5.0-DEVELOPMENT (amd64)
built on Mon Sep 09 20:57:57 EDT 2019
FreeBSD 12.0-RELEASE-p10

Files

Снимок экрана от 2019-09-10 13-55-27.png (63.2 KB) Снимок экрана от 2019-09-10 13-55-27.png Viktor Gurov, 09/10/2019 05:56 AM
Actions
Copy link
 #1

Updated by Jim Pingle about 5 years ago

  • Category changed from Web Interface to PPP Interfaces
  • Status changed from New to Confirmed
  • Affected Architecture All added
  • Affected Architecture deleted ()
Actions
Copy link
 #2

Updated by Jim Pingle about 5 years ago

The way the page is rendered is odd.

  • The Local IP address, mask, and gateway are stored in an array indexed by a number (e.g. 0 for the first entry)
  • The interfaces are stored as an array indexed by number (e.g. 0 for the first entry)
  • The form populates values as if there is one entry for each possible interface, starting with 0
  • The form assumes the stored port and IP address info index numbers are the same as the index of the total number of interfaces

So the form only works if you use the first N interfaces, not a later interface. I've got some ideas on a fix.

Actions
Copy link
 #3

Updated by Jim Pingle about 5 years ago

  • Status changed from Confirmed to Assigned
  • Assignee set to Jim Pingle
Actions
Copy link
 #4

Updated by Jim Pingle about 5 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Viktor Gurov about 5 years ago

Jim Pingle wrote:

Applied in changeset d81f270454ec66680cb645c0d3c13f9431d9c026.

checked with L2TP and PPTP
ok now

Resolved

Actions
Copy link
 #6

Updated by Jim Pingle about 5 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #7

Updated by Jim Pingle about 5 years ago

  • Target version changed from 2.5.0 to 2.4.5
Actions
Copy link
 #8

Updated by Jim Pingle almost 5 years ago

  • Status changed from Resolved to Feedback

Needs checked and/or tested again on 2.4.5 snapshots

Actions
Copy link
 #9

Updated by Viktor Gurov almost 5 years ago

Jim Pingle wrote:

Needs checked and/or tested again on 2.4.5 snapshots

tested on 2.4.5.a.20191205.1442_3

ok, Resolved

Actions
Copy link
 #10

Updated by Jim Pingle almost 5 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF