Project

General

Profile

Bug #9741

interfaces_ppps_edit.php: WebGUI don't show local ip / gateway ip values

Added by Viktor Gurov about 1 month ago. Updated 22 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
PPP Interfaces
Target version:
Start date:
09/10/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.5.0
Affected Architecture:
All

Description

After adding L2TP / PPTP interfaces on Interfaces / PPPs pages
it add Local IP Address and Gateway IP or Hostname to config.xml
but don't show it if you press edit icon of interface

<ppp>
<ptpid>0</ptpid>
<type>l2tp</type>
<if>l2tp0</if>
<ports>vtnet1</ports>
<username>user1</username>
<password>MTIz</password>
<descr><![CDATA[2123312]]></descr>
<localip>1.2.3.4</localip>
<subnet>31</subnet>
<gateway>10.1.0.5</gateway>
<bandwidth></bandwidth>
<mtu></mtu>
<mru></mru>
<mrru></mrru>
</ppp>

issue on 2.4.4-p3
and
2.5.0-DEVELOPMENT (amd64)
built on Mon Sep 09 20:57:57 EDT 2019
FreeBSD 12.0-RELEASE-p10

Associated revisions

Revision d81f2704 (diff)
Added by Jim Pingle about 1 month ago

Fix interface/config alignment on interfaces_ppps_edit.php. Fixes #9741

Revision b0f317fd (diff)
Added by Jim Pingle about 1 month ago

Fix interface/config alignment on interfaces_ppps_edit.php. Fixes #9741

(cherry picked from commit d81f270454ec66680cb645c0d3c13f9431d9c026)

History

#1 Updated by Jim Pingle about 1 month ago

  • Category changed from Web Interface to PPP Interfaces
  • Status changed from New to Confirmed
  • Affected Architecture set to All

#2 Updated by Jim Pingle about 1 month ago

The way the page is rendered is odd.

  • The Local IP address, mask, and gateway are stored in an array indexed by a number (e.g. 0 for the first entry)
  • The interfaces are stored as an array indexed by number (e.g. 0 for the first entry)
  • The form populates values as if there is one entry for each possible interface, starting with 0
  • The form assumes the stored port and IP address info index numbers are the same as the index of the total number of interfaces

So the form only works if you use the first N interfaces, not a later interface. I've got some ideas on a fix.

#3 Updated by Jim Pingle about 1 month ago

  • Status changed from Confirmed to Assigned
  • Assignee set to Jim Pingle

#4 Updated by Jim Pingle about 1 month ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

#5 Updated by Viktor Gurov 22 days ago

Jim Pingle wrote:

Applied in changeset d81f270454ec66680cb645c0d3c13f9431d9c026.

checked with L2TP and PPTP
ok now

Resolved

#6 Updated by Jim Pingle 22 days ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF