Bug #9741
closed
interfaces_ppps_edit.php: WebGUI don't show local ip / gateway ip values
Added by Viktor Gurov over 6 years ago.
Updated over 6 years ago.
Affected Architecture:
All
Description
After adding L2TP / PPTP interfaces on Interfaces / PPPs pages
it add Local IP Address and Gateway IP or Hostname to config.xml
but don't show it if you press edit icon of interface
<ppp>
<ptpid>0</ptpid>
<type>l2tp</type>
<if>l2tp0</if>
<ports>vtnet1</ports>
<username>user1</username>
<password>MTIz</password>
<descr><![CDATA[2123312]]></descr>
<localip>1.2.3.4</localip>
<subnet>31</subnet>
<gateway>10.1.0.5</gateway>
<bandwidth></bandwidth>
<mtu></mtu>
<mru></mru>
<mrru></mrru>
</ppp>
issue on 2.4.4-p3
and
2.5.0-DEVELOPMENT (amd64)
built on Mon Sep 09 20:57:57 EDT 2019
FreeBSD 12.0-RELEASE-p10
Files
- Category changed from Web Interface to PPP Interfaces
- Status changed from New to Confirmed
- Affected Architecture All added
- Affected Architecture deleted (
)
The way the page is rendered is odd.
- The Local IP address, mask, and gateway are stored in an array indexed by a number (e.g. 0 for the first entry)
- The interfaces are stored as an array indexed by number (e.g. 0 for the first entry)
- The form populates values as if there is one entry for each possible interface, starting with 0
- The form assumes the stored port and IP address info index numbers are the same as the index of the total number of interfaces
So the form only works if you use the first N interfaces, not a later interface. I've got some ideas on a fix.
- Status changed from Confirmed to Assigned
- Assignee set to Jim Pingle
- Status changed from Assigned to Feedback
- % Done changed from 0 to 100
Applied in changeset commit:d81f270454ec66680cb645c0d3c13f9431d9c026.
Jim Pingle wrote:
Applied in changeset commit:d81f270454ec66680cb645c0d3c13f9431d9c026.
checked with L2TP and PPTP
ok now
Resolved
- Status changed from Feedback to Resolved
- Target version changed from 2.5.0 to 2.4.5
- Status changed from Resolved to Feedback
Needs checked and/or tested again on 2.4.5 snapshots
Jim Pingle wrote:
Needs checked and/or tested again on 2.4.5 snapshots
tested on 2.4.5.a.20191205.1442_3
ok, Resolved
- Status changed from Feedback to Resolved
Also available in: Atom
PDF