Project

General

Profile

Actions

Bug #9804

closed

services_captiveportal.php: Image upload does not validate file type

Added by Jim Pingle about 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Captive Portal
Target version:
Start date:
10/01/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

On services_captiveportal.php, uploaded image files are not validated properly. A user with access to the page could upload an arbitrary PHP file instead of an image file, and then use it to execute code/gain extra privileges/etc.

Actions #1

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Jim Pingle almost 2 years ago

  • Target version changed from 2.5.0 to 2.4.5
Actions #3

Updated by Chris Linstruth almost 2 years ago

I tested this and was unable to upload a small php script named phpinfo.gif into the picture widget.

I also tried it in captive portal and when it did not actually enable (because I didn't select an authentication server) I also got the invalid image message at the top. When I actually managed to enable captive portal to check I hit #9977 which, of course, broke everything.

Actions #4

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Resolved

That should be good enough. I also cannot upload anything but a valid image in those fields on 2.5.0, so it would appear this is fixed.

Actions #5

Updated by Jim Pingle over 1 year ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF