Project

General

Profile

Bug #9921

Limiters allow invalid delay values

Added by Steve Wheeler 13 days ago. Updated 5 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
Limiters
Target version:
Start date:
11/24/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

When creating Limiters the GUI allows delay values above 10000ms. The config also allow this and it is written into the generated ipfw ruleset:

        <queue>
            <name>15seconds</name>
            <number>2</number>
            <qlimit></qlimit>
            <plr></plr>
            <description></description>
            <bandwidth>
                <item>
                    <bw>1</bw>
                    <burst></burst>
                    <bwscale>Kb</bwscale>
                    <bwsched>none</bwsched>
                </item>
            </bandwidth>
            <enabled>on</enabled>
            <buckets></buckets>
            <mask>none</mask>
            <maskbits></maskbits>
            <maskbitsv6></maskbitsv6>
            <delay>15000</delay>
            <sched>wf2q+</sched>
            <aqm>droptail</aqm>
            <ecn></ecn>
        </queue>

pipe 2 config  bw 1Kb delay 15000 droptail
sched 2 config pipe 2 type wf2q+

However ipfw/dummynet does not allow delays longer than 10000ms:

[2.4.4-RELEASE][admin@7100.stevew.lan]/root: ipfw pipe 6 config delay 15000ms
ipfw: delay must be < 10000

The defined pipe is therefore not created. Worse is that ipfw stops processing the ruleset at that point so any pipes defined after that are also not created.
This results in any rules using those pipes just dropping the matched traffic.

Associated revisions

Revision 8afa74bb (diff)
Added by Jim Pingle 12 days ago

Enforce limiter delay 0<=x<=10000. Fixes #9921

Revision ab5ef410 (diff)
Added by Jim Pingle 12 days ago

Enforce limiter delay 0<=x<=10000. Fixes #9921

(cherry picked from commit 8afa74bb099d75962a5efb8a603981c0249f91a0)

History

#1 Updated by Jim Pingle 13 days ago

  • Assignee set to Jim Pingle

#2 Updated by Jim Pingle 12 days ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle 5 days ago

  • Target version changed from 2.5.0 to 2.4.5

Also available in: Atom PDF