Bug #9933
Captive Portal + Voucher not keeping auto-added "Pass-through MAC Auto Entry"
Start date:
11/28/2019
Due date:
% Done:
100%
Estimated time:
Affected Version:
2.4.4-p3
Affected Architecture:
All
Release Notes:
Default
Description
With Captive Portal, the "Enabled Pass-through MAC Auto Entry" should normally keep definitvly the MAC address into table. Regarding documentation there is only one way to delete it: manually.
But in version 2.4.4p3, the auto-added Mac is deleted in same time than Voucher expiration.
Correction find with Forum and Gertjan help.
https://forum.netgate.com/topic/148464/captive-portal-voucher-not-keeping-auto-added-pass-through-mac-auto-entry/4
the captiveportal.inc file , function captiveportal_prune_old_automac() has a block to remove MAC from list.
Solution:
Keeping log Voucher is expired, remove code about deleting rules and table auto-added line.
Associated revisions
History
#1
Updated by Viktor Gurov 11 months ago
Updated by #2
Updated by Jim Pingle 11 months ago
Updated by - Status changed from New to Pull Request Review
- Target version changed from Future to 2.5.0
#3
Updated by Renato Botelho 10 months ago
Updated by - Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
#4
Updated by Viktor Gurov 9 months ago
- Status changed from Feedback to Resolved
works as expected on 2.5.0.a.20200709.1250
Captive Portal keep Pass-through MAC Auto Entry. Issue #9933