Project

General

Profile

Actions

Bug #9963

closed

DNS servers assigned dynamically are omitted if also assigned manually when override is disallowed

Added by Jim Pingle almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
DNS Resolver
Target version:
Start date:
12/10/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

If:

  • A name server is manually configured, such as 8.8.8.8, under System > General
  • That same name server is also assigned dynamically (DHCP, PPPoE, etc)
  • And DNS Server Override is unchecked

Then that name server is incorrectly omitted from the system name servers.

It looks like the code is trying to avoid duplication, but didn't account for this case.

Actions #1

Updated by Jim Pingle almost 2 years ago

This seems to primarily be a problem just after unchecking the DNS Server Override box, as later the servers are prevented from being in the list originally. So there is somewhat of a race condition at play.

Actions #2

Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #3

Updated by Jim Pingle almost 2 years ago

  • Target version changed from 2.5.0 to 2.4.5
Actions #4

Updated by Jim Pingle almost 2 years ago

Easiest way to reproduce:

  • Enable forwarding in the DNS Resolver (Or forwarder, behavior is likely the same but I only checked resolver)
  • Check DNS Server Override on System > General, save, then reboot or at least save/apply WAN)
  • Set a DNS server on System > General that is the same as one supplied via DHCP on WAN, save
  • Check that it's in /var/unbound/unbound.conf as a forward-addr entry
  • Check DNS Server Override on System > General, save, and check /var/unbound/unbound.conf and see if the manually added entry is a forward-addr

Without this change, the DNS server will be missing from the list (and if they all overlap, there will be no forwarders and resolving will fail). With this change, it should be a forward-addr either way.

Actions #5

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Resolved

Works as expected on 2.4.5.a.20191219.0146

Actions

Also available in: Atom PDF