DNS servers assigned dynamically are omitted if also assigned manually when override is disallowed
- A name server is manually configured, such as 18.104.22.168, under System > General
- That same name server is also assigned dynamically (DHCP, PPPoE, etc)
- And DNS Server Override is unchecked
Then that name server is incorrectly omitted from the system name servers.
It looks like the code is trying to avoid duplication, but didn't account for this case.
Updated by Jim Pingle about 2 years ago
Easiest way to reproduce:
- Enable forwarding in the DNS Resolver (Or forwarder, behavior is likely the same but I only checked resolver)
- Check DNS Server Override on System > General, save, then reboot or at least save/apply WAN)
- Set a DNS server on System > General that is the same as one supplied via DHCP on WAN, save
- Check that it's in /var/unbound/unbound.conf as a forward-addr entry
- Check DNS Server Override on System > General, save, and check /var/unbound/unbound.conf and see if the manually added entry is a forward-addr
Without this change, the DNS server will be missing from the list (and if they all overlap, there will be no forwarders and resolving will fail). With this change, it should be a forward-addr either way.