pfSense

Merge backup_vip_function to the synchronize code where its only used.

• Create two new functions lock($subsystem)/unlock() to have more reliable locking using semaphores.
  This function can sleep till the resource is free and can help find not well behaving code.
• Remove most of the config_lock/config_unlock logics on the whole scripts/pages it is an abuse of this....

Remove another unused function.

Move exec_command function to util.inc.

Rename filter_translate_type_to_real_interface to interface_translate_type_to_real
Move this function to interfaces.inc where it belongs.

Remove unused function and function that provide the same functionality as php built-in ones.

Remove function that is present on php5.

• Teach get_interface_subnet() about carp.
• Increase scope to all interfaces when searching for the carp parent since the later is used even on those scopes.
• General cleanup of unused vars and code.

• Shuffle functions around to reduce require_once() a little.

• Convert schedules to pf(4).
  This allows to schedule the whole feature of the rules like queues/limiters/gateways/blocks/allows/etc...
• Whitespace cleaning on filter.inc
• Move schedule backend logic from pfsense-utils.inc to filter.inc and prefix with filter_....

• Move other functions around to where it makes sense.
• Reduce somewhat require_once() overhead by removing the includes from gwlb.inc they are not needed.
  Some more analysis is needed on the include path

More functions moving from pfsense-utils to interfaces.inc.

Fix "disable checksum offloading", and some other bugs with certain combinations of options while here.

• Make the carp ip fix for ipsec more general so other services that use the same methodology work.
  - Basically get_interface_ip() now knows how to handle carp(4).
• Move interface related function from pfsense-utils.inc to interfaces.inc that is their place....

Match 1.X behavior for PF macros. pptp and pppoe should be lowercase macros.

Fix polling.

Raise tab char count to 82

Bumb value to > 70 for dropdown invocation.

Convert tab strips into a select dropdown when there are more than 50
characters appearing in the tab names combined.

Improve the matching of carp ints to IPs.
Previously this stristr substring match would return incorrect/unexpected results. 10.0.0.1 would also match 10.0.0.16, 10.0.0.135. Adding a space to the IP to check will only match the specific IP given, since it is followed by spaces in the ifconfig output.

• Hide interfaces internals to other code and use the propper interfaces.
  Basically use get_interface*() functions instead of accessing fields like 'ipaddr'/'descr' etc...
• Make get_interfaces_with_gateway less heavyweight by getting information from the configuration stored in config.xml...

• Keep only one function to return the mac address
• Bring the mac address function to interfaces.inc its the only consumer of those.

Remove ftp-proxy/pftpx/ftpsesame references we handle all of this in kernel now.(yay!)

cleanup minor javascript issues

Reverse style fixes to get our subnet mask listed backed from get_interface_info()

Fix display of DHCP status on Status -> Interfaces

Convert Status:Queues to ajax. This changes makes it no finally block the user interface and makes this page usable again.

Revert "Merge IPv6 changes"

This reverts commit 1f9f2a95b7b42cf33e730535092e56e214fdb848.

Conflicts:

etc/inc/filter.inc
        etc/inc/interfaces.inc
        etc/inc/pfsense-utils.inc

Fix get_interface_info function.

Correctly show actions such as Connect/Disconnect on Status Interfaces page.

Make the rc.banner a lot more faster.

Remove debug message.

Make sure we do not return the interface passed as parameter rather NULL.

Set CURLOPT_TIMEOUT to 0

Small cleanup.

Make L2TP known in other parts of system, schedules and the function get_interface_ip.

Add more L2TP improvements.

Merge IPv6 changes

Replace another route -n get command. These can sometimes hang and cause a filter reload to get stuck.
Always use netstat -rn instead, these behave differently and can not hang according to ermal@

Add a function that compares current DNS to the dnscache file.
If they are not identical it will return the old Ip addresses which can
be used for removal of old items before adding new ones.
This is used by the rc.newipsecdns script when the remote ipsec gateway...

Remove enable_rrd_graphing()

Add unknown values for the extra data sources during boot

make sure the update fields are in the correct order

Move rrd graph data gathering over to pfctl instead of netstat, this uses 64 bit counters

Move command line after comment

Invoke pfctl for stats once and work with the output

• Use 64 bit counters from PF for interfafe stats
• Add block packets / traffic count, too

Actually get the whole command output.

Better handle floating rules.

Update shcedule code to new world order!

Correct field value to check

Cosmetic change to use the available function instead of replicating the process here.

Remove quality graph backend, this is now apinger territory

Nuke stray n's

• Add interface_supports_polling()
• Use interface_supports_polling()

• Honor $config['system']['polling'
• Enable / disable polling even if we are not booting.

Remove function call not needed.

Would be good to give this function a sync/refresh with filter.inc changes.

Bring back to life tdr_create_ipfw_rule.

Remove debugging.

Introduce 2 new functions
find_interface_subnet and get_interface_subnet
similar to their ip ones
find_interface_ip and get_interface_ip
to easy getting this info for dynamic interfaces.

Improve monitor IP lookup

Simplify and return correct information if dhcpd is active.

Add backtrace in the logs whenever log_error is called and debugging($g["debug"] ) is active.

Do not attempt to toggle polling on unsupported interfaces.

MFC: after testing confirms working with and without polling

Fix typo.

• Rename link_int_to_bridge_interface to link_interface_to_bridge
• Create two new function link_interface_to_{gif,gre}

Do not parse vlans

Do not step on var

Do not toggle polling on vlan interfaces

Fix up functions for dynamic gateways

• Rename get_current_wan_address to get_interface_ip
• Rename get_real_wan_interface to get_real_interface
• Simplify get_interface_ip by using find_interface_ip which should help in speed to since its using caching. Pointed by billm@
• Cleanup some code when passing or remove some unused one.

Remove unused var.

• Add run_plugins() function
• Use run_plugins() function in filter.inc
• Add plugin hook for parse_config and write_config

Cleanup some not needed code and use the correct debug var.
A lot of code references $debug as var but actually there is only $g['debug'] and $debugging that are defined!!

Revert this and see if it affects any of problem reported on latest builds.

Read in tabcontrols.php and properly eval()

If /usr/local/www/themes/$themename/tabcontrols.php exists, then eval
it and allow the tabbing colors and nifty corners to be overriden.

The file simply needs to look like:

$tab_active_bg = "#EEEEEE";
$tab_inactive_bg = "#777777";...

No need to lock config when setting filter update status

• Remove bigpond support from backend.
• Use killbypid instead of sigkillbypid SIGUSR2 is not doing what is expected.
• Actually start pppoe/pptp when the routing is called for this.

Cleanup the status queues so it does not does stupid things.
Apparnetly this needs to be converted to 'ajax' calls as the traffic graph but for now live with this.

Reffer to correct variable

Set full path to ping

If we really can't find what to ping just continue with the next graph

Remove dependency on WAN having the default route.
Also failed because it did not use the full path to /sbin

Make sure we get a valid address to ping for the rrd graphs.

Remove unrelated code from function. Add some style(9) to code so readability is improved.

Fix Wireless detection logic

Search disabled interfaces too, this is needed since some code assumes this(i.e. wireless).

Correctly gather statictics for virtual interfaces. Maybe bridge needs to be added to the list but i will have to test that further.

Remove the ppp hack from filter_translate_type_to_real_interface we know better now.

• Fixup stray dots('...') on bootup and add some comments since we do loading of the filters twice during bootup?!
• Merge all interface related bootstraps under interfaces_configure so this allows us to handle propperly assigned bridge/gre/gif/.. devices that might are initialized later than assigned interfaces....

• Array checks too.
• Add some style(9)

NOTE: Maybe someone needs to verify these strange checks on this function!

Make sure that convert_friendly_to_real also works for disabled interfaces.

• Do not return on CDROM platform
• Use @ to send error to /dev/null

Integrate part of the patch from ticket #1807.

The other part is already done on pppoe_up script in /usr/local/sbin.

Check if items are an array before treating them as such.

Fix detection if an interface is part of bridge.

Bring bridge related support functions up to date with the other bridge code.

NOTE: that the function link_int_to_bridge_interface needs a friendly interface as a parameter now i.e. "wan/lan/optX".

No need for the 'filtering bridge' option with if_bridge(4).

Cleanup authentication code. The basic auth method, the passwd, htpasswd
and pam backing functions have been removed. The basic auth method was
legacy code and the backing functions were redundant with no added value
that I could see. A simplified replacement backing function named...