pfSense

Fix indent and spaces

Fix #3790:

- Do not let 2 interfaces to setup the same track6 prefix id
- Show correct prefix id range for each interface

Change text and color delimiter to carat sign

To match change made in functions.inc.php

Gateway Status Widget keep IP address bold

Forum: https://forum.pfsense.org/index.php?topic=85187.msg467438#msg467438

The bold is specified literally in gateways.widget.php for the gateway IP box, so we need to send it bold from here also when providing an update....

Fixup text rule should be route

This code was obviously taken from firewall rules and reused here without changing the word "rule" to "route".

Remove spurious '>', fixes #4091

Standardise css list padding

for the_wall theme

Standardise css list padding

for pfsense_ng_fs theme

Standardise css list padding

for pfsense theme

Standardise css list padding

for pfsense-dropdown theme

Standardise css list padding

for nervecenter theme

Standardise css list padding

for metallic theme

Standardise css list padding

for code-red theme

Standardise css list padding

for _corporate

Standardise css list padding

On Status->Services, the Services Status widget when a service status is down, the red "x" button does not line up with the green "running" button in the column.
This is because listbg has:
padding-right: 16px;
But the normal listr has:...

Set text and color of Gateways Widget Status

getstats.php calls functions.inc.php get_stats(), which calls get_gatewaystats().
get_gatewaystats() now returns the text for each field and an optional color separated by "/" - "text/color" e.g. "Online/#90EE90"...

Explicitly pass gateway status and color

This code was passing a whole load of html to attempt to set various properties of the Gateways Widget Status column so that it would display the new status (Online, Offline...) and in the appropriate color.
Now that I am using class=listr, the css fro listr already specifies white. Setting bgcolor in HTML does not override that....

Use proper listr class for Gateways Widget Status

The Gateways Widget Status was not using the listr class, and so it was missing the borders for the right and bottom of its box.
Use the listr class.
Then use javascript to explicitly set the background-color to match the status, overriding the white that is specified in listr.

Fix gateway widget status update

Redmine #4077

Don't include link-locals as unbound interface candidates

Unbound does not presently support link-local interfaces.

Provide friendly descr in error message in Interfaces Assign

I was doing drastic things testing some stuff, swapping WAN and OPT1 interfaces in Interfaces->Assign. I accidentally pressed Save when I had the same real device selected for both. Thankfully there was input validation! But I noticed that the error message reported just the names WAN and OPT1, but actual I had them named as different things. So the names in the error message did not match the names (friendly descriptions) in the table of interfaces....

Merge pull request #1363 from phil-davis/patch-3

Put -4 in the right place in ntpq clockver command #4074

I had pasted it in here between "-c" and "clockvar", that was not good.
That's all I have for #4074 (I hope)

Use IPv4 for ntpq if IPv6 not allowed in widget #4074

Similar code here. Shame it was not in a subroutine called from both places, but not about to re-engineer that now:)

Use IPv4 for ntpq if IPv6 not allowed

Forum: https://forum.pfsense.org/index.php?topic=84890.0

Display installed pkg version even if pkg server not available

Forum: https://forum.pfsense.org/index.php?topic=84820.0
It seems reasonable to me to display the currently installed package version numbers, along with text like "Latest: N/A". and the Version box being red-filled when someone goes to System->Packages and displays the installed packages but the package server is not reachable for some reason....

Merge pull request #1348 from phil-davis/patch-4

Try to not make useless entries in the config file for very rare used configuration values. Makes config file readble and with less size

validate MTU and MSS as integers, and don't allow MSS larger than pf will accept to avoid broken rulesets.

Add input validation on vpn_ipsec_settings.php. Fixes #4052.

Fix input validation for DNS resolver when localhost is enabled in resolv.conf and "all" chosen in Network Interfaces. While here, set something other than '' when all is chosen.

Add input validation to Unbound advanced settings page. Ticket #4050

Validate as integers, not just numeric, to prevent possible breakage.

Add option to disable auto-added access-control entries for users who want to manually manage ACLs. Ticket #4023

Unset any previous dat

Use the pfsense module functions rather than execing. Fixes also possible attack vectors.

Use the pfsense module functions rather than execing. Fixes also possible attack vectors.

convert_real_interface_to_friendly_interface_name() goes and checks the parent and this gives wrong information 99.9 percent of the time on scenarios like when this is called for unassigned vlans etc, while its real purpose is just to check if the interface is assigned and return the intermeddiate/config name of the interface. Leave the get_parent_option there in the function but it needs to be asked specifically for.

Fix JavaScript confirmation dialog for EasyRule.

Remove a blank row in the tab display during firmware update

Reorder the inclusion of headers so that globals.inc comes first

Send the gateway name to this function. Fixes #4047

If localhost is configured to be included in resolv.conf, force its selection in Unbound. The resolv.conf logic prevents that from being a problem, but people don't seem to realize they have to pick that to use Unbound for the host itself. Force it here rather than just silently skipping its inclusion in resolv.conf.

fix text here, variables came back empty and aren't all that useful here anyway.

only show aggressive/main mode for IKEv1

Unset the aggressive mode settings for not IKEv1 settings

fix IPsec widget status display after recent changes broke it. Ticket #4045

Show Mtu on status interfaces.

Ticket #2786 there is an issue with convert_real_interface_to_friendly_interface which might return not expected data as in the situation checked for vlan case her ein the validation. Avoid for this case here the issue to allow properly setting mtu on vlans with not assigned parent.

Option for browser tab text order

Option for browser tab text order

Easy thing to do - add an option for the user to select if they want the host name or page name text to display first in the browser tab.
Forum: https://forum.pfsense.org/index.php?topic=84528.0

fix up text

Make this note more accurate.

Fixes #4039 remove the toggle from IPSec settings since its not anymore useful.

Fixes #4037
Revert "Do not let the user mess with SAs from this page. The daemon and primary status page handles tat"

This reverts commit bb55330aca91eb556df4ab7a21fe42d1d7899f8e.

Fixes #4015. Hide Negotiation mode when in IKEv2 since it is not required.

Removing extra closing bracket

Don't unset these items for PPP configurations as they're not configured here and doing so loses settings configured in interfaces_ppps_edit.php. Ticket #3727

phone number is a required field

fix up text

Fix input validation of custom-type dynamic DNS hostnames.

Properly remove IPv6 carp vips as reported from https://forum.pfsense.org/index.php?topic=84392.0

Change wording at the end of the wizard to remove "donate" since that is no longer an option

Add a note to the wizard about the DNS Resolver ignoring manual name servers by default.

Add .inc file for gmirror status widget to give it a better title and link to the management page.

Fixes #3727 Do not unset configuration values from ppp config if not needed.

Balh typos

When reinstalling a package try to start it after to avoid non-expectations from people

Remove debugging code that can lead us to XSS injection, also pass variables through htmlspecialchars() to sanitize

Force pkg reinstall when asked for.

Display Resolver host override aliases

On the main unbound resolver GUI page, like they display on the dnsmasq forwarder GIU page.
As per forum: https://forum.pfsense.org/index.php?topic=78356.msg462345#msg462345

Remove var_dump from production code

Remove var_dump from production code

Ticket #3987. Strongswan support autodetection of IKE version exchange. Support this by allowing an auto version in the GUI.

Pass path parameter through htmlpecialchars()

Define a local boolean var for showact to avoid security issues, also pass order parameter trough htmlspecialchars()

Fix whitespace and indent

Merge pull request #1341 from phil-davis/patch-6

Merge pull request #1332 from phil-davis/patch-3

Merge pull request #1331 from phil-davis/patch-2

Make OpenVPN desccriptions appear in interfaces assign dropdown

As reported in forum https://forum.pfsense.org/index.php?topic=84251.0
The fix turned out to be easy.

Clean up unbound advanced page HTML

Merge pull request #1338 from SilvioGiunge/change_system_usermanager_settings_test_page

Clear dirty subsystem for hosts and staticmaps when unbound is enabled

Don't show a big red "alarm"-looking message on every visit to the DHCP/DHCPv6 Server pages. Confuses people in that context, and it's not something that justifies highlighting in such a fashion. Move the message to show when you have no eligible interfaces.

Use appropriate size for the interface selects. Ticket #3989. clean up some text while here

fix Unbound Advanced options

Changes in the test page of user manager

6RD Rapid Deployment is akin to ATM Machine, PIN Number, ... read: it's redundant. let's just call it 6RD Configuration.

Make sure dhcpleases use correct pid file for dnsmasq or unbound. Fixes #4008

outbound NAT can apply to any type of interface, make WAN-type specific reference generic

geom part list no longer lists empty disks, compensate where needed.
Also, while I'm here, fixup copyright.

Merge pull request #1335 from brunostein/remove_multiple_groups

Merge pull request #1334 from brunostein/remove_multiple_users

Make sure $cpzoneid is defined and use it to call pfSense_ipfw_Tableaction() and pfSense_ipfw_getTablestats(). Also fix fieldnames for captiveportal_hostnames. It should fix #4001

Do not show the user/pass for pre shared key on Openvpn since its not-supported.

Change this line slightly, for some reason it is making my editor crash with the old line.

remove checkall checkbox

add checkbox on the left side of the table and remove checkall checkbox

add tr id