pfSense

Add nav-wrapper to loose buttons

Don't use $section2, toggle all remote-options when disabled

pfSense.js - Force correct initial state for toggleable checkboxes #143

Prepare for different width, make widths static

refs #141

Merge pull request #134 from sbeaver-netgate/diag_logs_settings.php

Converted diag_logs_settings.php

Form - show all global Buttons in a single wrapper

fixes #135

Replaced js with toggles

Also eliminated unneeded gettext from help

Converted system_certmanager

fixes #106

Replace js with addClass to set button class

Also removed htmlspecialcharacters() where not required

diag_logs_settings replace ugly help with staticText

diag_logs_settings Removed bogus print_r

Also removed unneeded gettext

Merge pull request #87 from sbeaver-netgate/diag_tables

Converted diag_tables.php

Merge pull request #138 from sbeaver-netgate/system

Bugfix: properly store timezone + don't close <a> twice

Merge pull request #109 from sbeaver-netgate/diag_logs

Converted diag_logs.php

Merge pull request #100 from sbeaver-netgate/halt

Updated halt.php for consistency with reboot.php

system.php bugfix

$timezonelist was an indexed array, causing the page to save the index
in the config, not the value.

Merge pull request #136 from Bouwdie/services_wol

Converted services_wol

Removed double newlines.
Removed onclick event.

Remove unneeded gettext in setHelp() call

Removed unneeded table elements and HTML input elements

Ready for review

#126
Link_interface_to_bridge check also applied to wol_edit.
Inverted link_interface_to_bridge check to be more clear.

Re-enstate copyright that got lost in pull request

Refs. #99

#126
Added required classes to table.

#126
Wrapped table in table responsive div.

#126
Removed gettext calls when creation form parts; this is done by the form class
Removed obsolete submit button on edit form; this is created by default.
Use single quotes for php strings

- Fix broken source address input & replace one-time method with array_merge
- Removed redundant htmlspecialchar and gettext methods; the form class itself takes care of this
- Slightly modified output panel to match other panels

Refs. #99

Merge pull request #99 from sbeaver-netgate/diag_testport

Diag testport

Replace +- with explanatory buttons

Refs. #45

diag_logs_settings.php conversion complete

#126
Ran clear.sh.
Replaced forms with Form builder.
Introduced an extra panel for the WOL devices.

Added btn-sm class to buttons.

daig_logs.php conversion complete

This conversion relies on a change to guiconfig.inc.

A new function was added: dump_clog_no_table() which performs the same
tasks as dump_clog() but does not output table elements.

This function can replace dump_clog() when all of the diag_log*.php...

Toggle classes should be attached to group, not input (so that help toggles with group)

Refs. #18

Update display_top_tabs to use pills as default

Refs. #107

dig_tables.php revised to use Form.classe

Would you please review these changes and let me have your comments.

I will remove the “echo” statements once I have your comments.

Merge branch 'bootstrap' into halt

Conflicts:
usr/local/www/halt.php

Merge branch 'bootstrap' of https://github.com/SjonHortensius/pfsense into bootstrap

Add title to separate form and table

Refs. #22

fix last line

refs #95

Merge pull request #95 from sbeaver-netgate/reboot

Converted reboot.php

Updated for consistency with reboot.php

Updated for consistency with reboot.php

Fixed bad copy/paste :(

appended some missing fixes in system_camanager.php

Converted system_camanager

bindCollapseToOptions - support multiple options targeting single section

fix #96

Supdated per SH

Good suggestions. Thank you.

Remove alternative version

IpAddress - set correct validationpattern, toggle mask based on family

Skip inline gw creation; it should be a Modal that inlines /gw_edit

IpAddress - move from max mask=32 to 128, removed method-default @ fw_edit

Converted system_routes*, pending implementation of direct gw addition

pfSense.js - add confirm to .btn-danger elements; removed onclicks

Focus first input globally

Complete conversion; add <form>, remove dead sntxhgh, use events

refs #94

Merge pull request #94 from sbeaver-netgate/edit_file

Convert edit.php

correct nesting & whitespace, then run away from this page fast

also no need for popen, you can simply use system() instead

refs #92

Merge pull request #92 from sbeaver-netgate/exec

Convert exec.php

Completed diag_routes, add panels, fix generated tables

refs #91

Merge branch 'diag_routes' of https://github.com/sbeaver-netgate/pfsense into sbeaver-netgate-diag_routes

refs #91

Completed diag_ndp, made consistent with status_dhcp_leases

refs #85

Merge pull request #85 from sbeaver-netgate/diag_ndp

Convert diag_ndp.php

Completed diag_limiter_info.php; made consistent with other pages

refs #83

Merge pull request #83 from sbeaver-netgate/diag_limiter_info

Convert diag_limiter_info.php

Reorder elements, use events, remove table

refs #79

Merge pull request #79 from sbeaver-netgate/diag_system_activity

Converted diag_system_activity

Completed conversion of diag_pf_info - introduce Form

Merge pull request #77 from sbeaver-netgate/diag_pf_info

Converted diag_pf_info.php

complete conversion of diag_system_pftop.php

refs #70

make construct less strict to allow hiding submit button

Merge pull request #70 from sbeaver-netgate/diag_system_pftop

Converted diag_system_pftop

Revised per SvL comments

Thank you.

- Remove htmlspecialchars; Form_Element->__toString() already encodes attribute values
- Use password input type for password

Refs. #81

Merge pull request #81 from sbeaver-netgate/diag_authentication

Conversion of diag_authentication completed

Some more rigorous rewrite of diag_states_summary

- Replace table in table with table cells spanning two or more rows
- Removed redundant panel
- Removed column width classes from table cells; they're not intended for this usage

Refs. #78

Merge pull request #78 from sbeaver-netgate/diag_states_summary

Diag states summary

Tweak converted halt.php

- Replace 'submit' with 'save', which is more in line with the Form.class
- Add h2 panel title
- Just match string instead of stristr of gettext result

Refs. #75

Table replaced with panel

Thank you for your suggestion. I will revisit other pages that use
tables and make the same change.

Merge pull request #75 from sbeaver-netgate/halt

Merge updated halt.php

edit.php - Fixed tester class

edit.php - Form field class corrected

edit.php conversion complete

This was a tricky conversion because of the included JS libraries and
the in-line JS functions.
Syntax highlighting has been eliminated (because it had never worked
and is not needed).

The files:
filebrowser/*
javascript/base64.js...

exec.php conversion complete

Tables eliminated, panels added, panels re-ordered to place output near
the control that generated it. Messages converted to alerts.

Reverted change - Wrong branch :(

diag_exec.php conversion complete

Page re-factored to display output in panels and to put the
warnings/messages alongside the control that generated them.

dig_routes Update complete

Javascript required update for bootstrap compatibility.
Form.class.php updated so that form button is not drawn if the button
name is empty.

2 minor typos

use proper variable to detect state

refs #69

Properly convert select > radios

refs #69

correct several typos, remove whitespace from pre

refs #69

Fix panel structure.

- Contents should be placed in a `.panel-body`, which adds proper padding.
- Title is wrapped in a H2, which is usually semantically correct when starting a new panel

Refs. #69

Updated per SH

Mostly :)

Conversion completed

Update completed

Completed

Ready for review

Conversion completed

Changes checkbox layout

Added braces for clarity around if(run)

Converted

Added some Ajax to allow the user to freeze the page (otherwise it is
not possible to view it before it refreshes)

Eliminate white space in Submit value

Updated

Updated to bootstrap

Use of Ajax in this file precluded the use of Form.classes

Table was replaced with bootstrap panel/row and input component classes
updated.