Project

General

Profile

« Previous | Next » 

Revision 085136fe

Added by Bipin Chandra over 10 years ago

multiple allow/deny entries for UPnP (rowhelper)

This patch will allow the web GUI for UPnP to enter more user specified
entries rather than just 4, I replaced the 4 boxes with one rowhelper
control

View differences:

usr/local/pkg/miniupnpd.inc
98 98
			$input_errors[] = 'You must specify a valid traffic shaping queue.';
99 99

  
100 100
		/* user permissions validation */
101
		for($i=1; $i<=4; $i++) {
101
		for ($i=0; $i<500; $i++){
102 102
			if($post["permuser{$i}"]) {
103 103
				$perm = explode(' ',$post["permuser{$i}"]);
104 104
				/* should explode to 4 args */
......
209 209
				$config_text .= "model_number=".file_get_contents("/etc/version")."\n";
210 210
	
211 211
				/* upnp access restrictions */
212
				for($i=1; $i<=4; $i++) {
213
					if($upnp_config["permuser{$i}"])
214
						$config_text .= "{$upnp_config["permuser{$i}"]}\n";
212
				foreach($upnp_config['row'] as $row){
213
					if($row['permuser'])
214
						$config_text .= "{$row["permuser"]}\n";
215 215
				}
216 216

  
217 217
				if($upnp_config['permdefault'])
usr/local/pkg/miniupnpd.xml
116 116
			<type>checkbox</type>
117 117
		</field>
118 118
		<field>
119
			<fielddescr>User specified permissions 1</fielddescr>
120
			<fieldname>permuser1</fieldname>
119
			<fielddescr>User specified permissions</fielddescr>
121 120
			<description>Format: [allow or deny] [ext port or range] [int ipaddr or ipaddr/CIDR] [int port or range]
122 121
			&lt;br /&gt;Example: allow 1024-65535 192.168.0.0/24 1024-65535</description>
123
			<type>input</type>
124
			<size>60</size>
122
			<type>rowhelper</type>
123
			<rowhelper>
124
				<rowhelperfield>
125
					<fieldname>permuser</fieldname>
126
					<type>input</type>
127
					<size>60</size>
128
				</rowhelperfield>
129
			</rowhelper>
125 130
		</field>
126
		<field>
127
			<fielddescr>User specified permissions 2</fielddescr>
128
			<fieldname>permuser2</fieldname>
129
			<description>Format: [allow or deny] [ext port or range] [int ipaddr or ipaddr/CIDR] [int port or range]</description>
130
			<type>input</type>
131
			<size>60</size>
132
		</field>
133
		<field>
134
			<fielddescr>User specified permissions 3</fielddescr>
135
			<fieldname>permuser3</fieldname>
136
			<description>Format: [allow or deny] [ext port or range] [int ipaddr or ipaddr/CIDR] [int port or range]</description>
137
			<type>input</type>
138
			<size>60</size>
139
		</field>
140
		<field>
141
			<fielddescr>User specified permissions 4</fielddescr>
142
			<fieldname>permuser4</fieldname>
143
			<description>Format: [allow or deny] [ext port or range] [int ipaddr or ipaddr/CIDR] [int port or range]</description>
144
			<type>input</type>
145
			<size>60</size>
146
		</field>	
147 131
	</fields>
148 132
	<custom_php_command_before_form>
149 133
		before_form_miniupnpd($pkg);

Also available in: Unified diff