pfSense

Tidy up GWG dropdown selection tests

Tested this making a new rule, and editing existing IPv4, IPv6 and IPv4+Ipv6 rules, and switching the IP version on an existing rule. Seems to work!

Tidy "gateway name - IP" in dropdown list

While I notice this also, for a plain gateway, the current IP address is also listed in the dropdown list text, like "WAN_DHCP - 10.42.11.1". If there is no IP address currently, it might say "WAN_DHCP - dynamic". But for some DHCP gateways that have not had any non-default manual settings done, it can say "OPT1_DHCP ". This gets rid of the silly-looking ""

Use return_gateway_groups_array() to build correct GWG list

Now return_gateway_groups_array() always returns at least the IP version 'ipprotocol' of each GWG, even if all its members are down at present. It is better to use this to check what IP version the GWG is. The previous check was using the IP address of the first member of the GWG to deduce 'ipprotocol'. That would fail if the WAN was DHCP and was down.

Add a function to read the status of connections/SAs/SPDs from smp plugin of StrongSWAN. No need to go through the setkey dumps

Port dropdowns: Put port no. after descrip

At the moment, even if a port number is entered, it's re-displayed only as a port name when editing. Users who don't have port names -> numbers lookup memorised can't easily confirm when editing a rule, that the port is as intended. Then, when they return to firewall_rules.php the same rules have ports displayed as numbers not names (inconsistent)....

Push log changes for IPSec and fix generation of strongswan.conf and ipsec.secrets to be properly considered

Fix #2302, save custom uploaded l7 pattern files on config.xml and replicate it to slave

Fix whitespaces and indent

This one too.

Element id's are to be unique. 'provider' used is elsewhere.