Project

General

Profile

« Previous | Next » 

Revision 5daccf2d

Added by Reid Linnemann almost 3 years ago

Fix undefined and unused variable warnings in interfaces.inc

Notes: * interfaces_tunnel_configure() * loop continue on address type "track6" never hit, defined variable is
'$ipaddrv6' but was referred to as '$ipaddr6' * interface_bring_down() * '$old_router' was populated with the contents of a file but never used * interface_ppps_configure() * no such variables '$dhcp_gateway' and '$gway' in log_error() when
'$gateways[$pid]' is not an ip address. This looks like a copy/paste bogon,
replaced the variables with what seemed to be appropriate bits from the
pppoe configuration - the local ip for the pid and the gateway for the ppp
link * interface_wireless_configure() * Missing variables '$wpa_supplicant_crt' and '$wpa_supplicant_key' defined
to match the composed cert and key file names given file_put_contents().
Previously the chmod()s would do nothing * Missing variable '$wpa_supplicant_ca' defined according to the composed
file name given to file_put_contents(). Previously the wpa_supplicant
config would have an empty ca_cert path * run_dhcp6client_process() * parameter '$debugOption' referred to as '$debugOptions' within the function * interface_track6_configure() * Missing '$type', which should be the switched $trackcfg['ipaddrv6'] value * interface_dhcpv6_configure() * No variable $ifdescr, replaced with $interface (logical interface name) * get_configured_vip_list_with_descr * No variable $vipid, $vipid defined as the iterated index and $vip the
configured vip gotten from get_configured_vip. Previously the configured
vip list returnd would likely be empty * restart_interface_services() * No variable $realif, replaced with interface 'if' attribute from config

  • added
  • modified
  • copied
  • renamed
  • deleted