pfSense

Fix #6482 OpenVPN Redirect Gateway Option Causes GUI Issue

This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked)....

added missing div.content wrapper when reloading filters

(cherry picked from commit e8406abe627675db2c2f77a81c1bb883f5158bb6)

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)

Fix bad escapeshellarg logic on mpd execution

With this change single-quotes are applied in correct places

(cherry picked from commit 08cd022545be58a46b860500ff81bbe7438b6304)

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....

missing "("
(cherry picked from commit 70381d4803b9424c1a3f3ef518d8243062452d77)

optional arg for old behaviour
(cherry picked from commit cf63f1638aab685cc956502f5ddd862a10bf3ff8)

function name hms -> dhms

to match edit to util.inc
(cherry picked from commit c57e936a6596550619f7261e85b633ca5016cbf2)

Simplify convert_seconds_to_hms() and show days for large numbers of hours

1) Function can be simplified and all "if" statements removed, using intdiv (or casting result as int for PHP < 7) and % for calcs and sprintf for padding.
2) Input validity check before trying to convert format...

Add "delete entry" for ARP table

Useful function in some circumstances - seems no reason not to have it.

Uses IP rather than hostname since not all ARP entries have hostnames.

Probably should also have "delete all" but not done that.
(cherry picked from commit 6ea0d41e3c094a0977e7f0d022ec74276280b8ff)