pfSense

Ancient bug on upgrade_014_to_015

This code looked silly the way it was, with the construct:
$var = $var;
unset($var);

Seems it was accidentally changed to this way many years ago by https://github.com/pfsense/pfsense/commit/588a183b0e58f09932ffef35cc0003cca2313aba...

Fix type (trime->trim)

interface_netgraph_needed can miss setting found equals true

This routine seems to go looking to see if the passed-in interface is PPP-style. At the end, if it is not PPP-style then it calls pfsense_ngctl_detach.
This foreach loop in its current state will always exit after the first iteration that is not mode "server". But it looks like it should look through all the 'pppoe' entries until it finds the interface or gets to the end....

remove unused legacy code

Log ifconfig commands used to setup wireless interfaces

Put the bits to use the new reset utility

Ticket #4418 Actually make each entry a clear token to strongswan parser for dns_split

Ticket #4418 make sure the dns_split is separated with spaces rather than space or comma to comply with strongswan requirements.

Ticket #4418 Make the DNS names attr 28675 space separated as identified by Jeffrey Dvornek

remove old, unused code