pfSense

Make sure there is a direction specified otherwise errors might occur.

Initialize rule keeping array to avoid possible caching effects on php.

Separate this into the original case with the floating rule cases above it to fix some scenarios where the order was still wrong.

Move this function to allow removing it from easyrule.

Fix filter_rules_sort's compare function to know about floating rules so it won't change their order.

Take into account if we have redirection active to allow even port 443.

Make the antilockout rule match the webgui and ssh(if enabled) rather than any traffic destined to pfSense itself.

• Call get_configured_interface_* functions only once in the code
• Optimize the test if the passed interface is a vaild one
• Fix the apply settings to actually do something rather than do nothing at all
• Some style and whitespace fixes

Small improvement no functional change.

Use php calls rather than forking to shell.