Project

General

Profile

Bug #10179

incorrect encrypted backup restore error handling

Added by Viktor Gurov 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Backup / Restore
Target version:
Start date:
01/11/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.4-p3
Affected Architecture:

Description

If you trying to restore encrypted backup, but select invalid file, you got blank page after pressing "restore" ( caused by 'return 1;' in code )
If you enter incorrect decryption password, you got error message:

A full configuration restore was selected but a pfsense tag could not be located.

which is incorrect, it should be:
File decryption failed. Incorrect password or file is invalid.

fix:
https://github.com/pfsense/pfsense/pull/4160

Associated revisions

Revision 153f78af (diff)
Added by Viktor Gurov 10 months ago

fix incorrect encrypted backup restore error handling. Issue #10179

Revision ce25d600 (diff)
Added by Viktor Gurov 10 months ago

fix incorrect encrypted backup restore error handling. Issue #10179

(cherry picked from commit 153f78af168e81e89792a92dc81ed719ce86296b)

History

#1 Updated by Viktor Gurov 10 months ago

  • Subject changed from incorrect encrypted backup restore error handling' to incorrect encrypted backup restore error handling

#2 Updated by Jim Pingle 10 months ago

  • Status changed from New to Pull Request Review
  • Assignee set to Jim Pingle
  • Target version set to 2.5.0

#3 Updated by Renato Botelho 10 months ago

  • Status changed from Pull Request Review to Feedback
  • Target version changed from 2.5.0 to 2.4.5
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to Resolved
  • Target version changed from 2.4.5 to 2.5.0

This is not detecting the incorrect password case on current 2.4.5 snapshots. I don't get a blank page on error like before, though, so it's still better.

It works as expected on 2.5.0 snapshots, so may be a difference in OpenSSL return results. It's not worth holding up the release over this, though, so moving it up.

Also available in: Atom PDF