Bug #10179
closed
incorrect encrypted backup restore error handling
Added by Viktor Gurov almost 5 years ago.
Updated almost 5 years ago.
Category:
Backup / Restore
Affected Version:
2.4.4-p3
Description
If you trying to restore encrypted backup, but select invalid file, you got blank page after pressing "restore" ( caused by 'return 1;' in code )
If you enter incorrect decryption password, you got error message:
A full configuration restore was selected but a pfsense tag could not be located.
which is incorrect, it should be:
File decryption failed. Incorrect password or file is invalid.
fix:
https://github.com/pfsense/pfsense/pull/4160
- Subject changed from incorrect encrypted backup restore error handling' to incorrect encrypted backup restore error handling
- Status changed from New to Pull Request Review
- Assignee set to Jim Pingle
- Target version set to 2.5.0
- Status changed from Pull Request Review to Feedback
- Target version changed from 2.5.0 to 2.4.5
- % Done changed from 0 to 100
PR has been merged. Thanks!
- Status changed from Feedback to Resolved
- Target version changed from 2.4.5 to 2.5.0
This is not detecting the incorrect password case on current 2.4.5 snapshots. I don't get a blank page on error like before, though, so it's still better.
It works as expected on 2.5.0 snapshots, so may be a difference in OpenSSL return results. It's not worth holding up the release over this, though, so moving it up.
Also available in: Atom
PDF
Updated by Viktor Gurov 
Updated by 
Updated by