Bug #10305
closed
Using special character in Schedules description
Added by Viktor Gurov almost 5 years ago.
Updated over 4 years ago.
Affected Version:
2.4.4-p3
Description
When using special characters in Schedules and timeranges description fields
firewall_schedule.php page shows escaping symbols, i.e.
Günter instead of Günter
Günter instead of Günter
This PR removes htmlentities($_POST['descr'], ENT_QUOTES, 'UTF-8'); (legacy code?)
from firewall_schedule_edit.php
and adds rangedescr to $cdata_fields array
It also sort $cdata_fields array alphabetically
https://github.com/pfsense/pfsense/pull/4214
- Affected Version set to 2.4.4-p3
- Status changed from New to Pull Request Review
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- Target version set to 2.5.0
- % Done changed from 0 to 100
PR has been merged. Thanks!
- Status changed from Feedback to Resolved
OK on 2.5.0.a.20200317.1949
- Status changed from Resolved to Feedback
- Target version changed from 2.5.0 to 2.4.5-p1
- Status changed from Feedback to Resolved
GUI looks good with the supplied test string. Descriptions show the expected string, and when editing the schedule, the expected string is in the fields without extra escaping.
Also available in: Atom
PDF