Project

General

Profile

Bug #10432

Arpwatch show unknown vendor

Added by Manuel Piovan about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
arpwatch
Target version:
-
Start date:
04/05/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.5.x
Affected Architecture:

Description

arpwatch.inc
line 164
if (preg_match("/^$oui\s+(.*)$/m", file_get_contents(ARPWATCH_LOCAL_DIR.'/ethercodes.dat'), $matches)) {
$vendor = $matches1;
} else {
$vendor = 'unknown';
}
the array is always empty,
ethercodes.dat is available and populated

Immagine.jpg (129 KB) Immagine.jpg Manuel Piovan, 04/05/2020 05:50 AM

History

#1 Updated by Manuel Piovan about 2 months ago

this is due to $oui = strtoupper(substr($mac, 0, 8));
the content of ethercodes.dat is not uppercase

PR https://github.com/pfsense/FreeBSD-ports/pull/831

#2 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review

#3 Updated by Renato Botelho about 2 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Viktor Gurov about 2 months ago

  • Status changed from Feedback to Resolved

shows correct vendors on 2.4.5/2.5 with arpwatch 0.2.0_1

Also available in: Atom PDF