pfSense

Patch committed.

the bug is not fixed. i have same problem with Intel X540-T2 and X520-DA cards. attached my configuration and output of ifconfig.
currently i use workaround using shellcmd package. i just run ifconfig ix(0-3) -lro using shellcmd, but i don't think that it is correct solution for production environment.

It still have problems, I'm working on it.

Applied in changeset a9e4412797c5f8caeb6c7579279b2ecc7d5bfe96.

Hi, LRO is working TSO4,TSO6 not working on LAGG interfaces.

ifconfig output:
ix0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=403bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,VLAN_HWTSO>
        ether 68:05:ca:0c:87:1e
        inet6 fe80::6a05:caff:fe0c:871e%ix0 prefixlen 64 scopeid 0x1
        nd6 options=3<PERFORMNUD,ACCEPT_RTADV>
        media: Ethernet autoselect
        status: no carrier
ix1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=403bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,VLAN_HWTSO>
        ether 68:05:ca:0c:87:1e
        inet6 fe80::6a05:caff:fe0c:871f%ix1 prefixlen 64 scopeid 0x2
        nd6 options=3<PERFORMNUD,ACCEPT_RTADV>
        media: Ethernet autoselect
        status: no carrier
bce0: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=c01bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,VLAN_HWTSO,LINKSTATE>
        ether d8:d3:85:b9:f4:14
        media: Ethernet autoselect
bce1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=c00bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,VLAN_HWTSO,LINKSTATE>
        ether d8:d3:85:b9:f4:16
        inet 192.168.100.1 netmask 0xffffff00 broadcast 192.168.100.255
        inet6 fe80::dad3:85ff:feb9:f416%bce1 prefixlen 64 scopeid 0x4
        nd6 options=1<PERFORMNUD>
        media: Ethernet autoselect (1000baseT <full-duplex>)
        status: active
ix2: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=403bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,VLAN_HWTSO>
        ether a0:36:9f:1d:d5:00
        inet6 fe80::a236:9fff:fe1d:d500%ix2 prefixlen 64 scopeid 0x5
        nd6 options=3<PERFORMNUD,ACCEPT_RTADV>
        media: Ethernet autoselect (10Gbase-Twinax <full-duplex>)
        status: active
ix3: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=403bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,VLAN_HWTSO>
        ether a0:36:9f:1d:d5:00
        inet6 fe80::a236:9fff:fe1d:d502%ix3 prefixlen 64 scopeid 0x6
        nd6 options=3<PERFORMNUD,ACCEPT_RTADV>
        media: Ethernet autoselect (10Gbase-Twinax <full-duplex>)
        status: active
enc0: flags=0<> metric 0 mtu 1536
pflog0: flags=100<PROMISC> metric 0 mtu 33144
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
        options=3<RXCSUM,TXCSUM>
        inet 127.0.0.1 netmask 0xff000000
        inet6 ::1 prefixlen 128
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x9
        nd6 options=3<PERFORMNUD,ACCEPT_RTADV>
pfsync0: flags=0<> metric 0 mtu 1460
        syncpeer: 224.0.0.240 maxupd: 128 syncok: 1
lagg0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=403bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,VLAN_HWTSO>
        ether 68:05:ca:0c:87:1e
        inet6 fe80::6a05:caff:fe0c:871e%lagg0 prefixlen 64 scopeid 0xb
        nd6 options=3<PERFORMNUD,ACCEPT_RTADV>
        media: Ethernet autoselect
        status: no carrier
        laggproto lacp
        laggport: ix1 flags=0<>
        laggport: ix0 flags=0<>
lagg1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=403bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,VLAN_HWTSO>
        ether a0:36:9f:1d:d5:00
        inet6 fe80::a236:9fff:fe1d:d500%lagg1 prefixlen 64 scopeid 0xc
        inet 10.165.128.211 netmask 0xffffff00 broadcast 10.165.128.255
        nd6 options=1<PERFORMNUD>
        media: Ethernet autoselect
        status: active
        laggproto lacp
        laggport: ix3 flags=1c<ACTIVE,COLLECTING,DISTRIBUTING>
        laggport: ix2 flags=1c<ACTIVE,COLLECTING,DISTRIBUTING>

This is an issue on 2.2. Example at 172.27.32.125, see its igb1 where igb1_vlan10 is assigned but igb1 isn't.

VLANs are skipped by flags settings.
Normally a reboot should apply the right thing to the interfaces.
Reconfiguration is to be seen, in terms of applying these settings or we should force reboot when these are changed.

In the circumstance described here, where the interface is in use but not directly assigned (so part of a LAGG, or a VLAN parent interface only), it's never applied to the affected interface. For instance, create lagg0 with em1 and em2 as members. em1 and em2 don't have TSO or hardware checksum set according to the system's config. Or create say em3_vlan10 and set the same there, then it's not applied to em3. Confirmed this again on latest snapshot.

Can you try with newer snapshots?

For lagg even here there should be a specific special case since it has to go through each member.
Though reboot handles lagg quite OK so i do not think at this stage is safe to change this.
Just put it on wiki that if you want changed flags on lagg need to reboot.

Applied in changeset 2535f6dcc2d0898f1c89c7c0a2606c95b3f59320.

reboot doesn't handle it correctly either. There is a clear test case on 172.27.32.125 with its lagg0 and members igb2 and igb3. Please test there, Ermal. That's a test box you can do anything you need to with any time.

Fixed Chris, though lagg still needs reboot to work on my vms and your test setup.

Applied in changeset 43517fcc1b616b7443b26247dc59dbd65bde2819.

fixed