Bug #10475
closed
pfSense-pkg-arpwatch unconditinally clobbers the arpwatch database files on upgrade
100%
Description
I was surprised to find that upgrading the pfSense-pkg-arpwatch package today nuked all of my .dat files. There is an option to "clear database" which it says it will do this before starting arpwatch but that's not really what happens.
Currently (0.2.0_1) the .dat files are removed on install if the clear database option is set. They are always removed on deinstall (independent of the option).
It would make a lot more sense to me if the only time .dat files were removed was on deinstall and only if the "clear database" option is set. This would allow the user to populate the .dat files before installing pfSense-pkg-arpwatch (and avoid removing them when upgrading).
I created pull request #844 to implement this change.
Updated by Jim Pingle about 5 years ago
- Project changed from pfSense to pfSense Packages
- Category set to arpwatch
- Status changed from New to Pull Request Review
Updated by Renato Botelho about 5 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
Updated by Viktor Gurov about 5 years ago
- Status changed from Feedback to Resolved
arpwatch 0.2.0_2 - works as expected
Updated by Viktor Gurov about 5 years ago
- Status changed from Resolved to New
fix for https://github.com/pfsense/FreeBSD-ports/pull/844
to correctly check 'clear_database' value
otherwise arpwatch mac db is never deleted:
https://github.com/pfsense/FreeBSD-ports/pull/854
Updated by Jim Pingle about 5 years ago
- Status changed from New to Pull Request Review
Updated by Craig Leres about 5 years ago
So the bug is the clear database checkbox was not being honored ever? "oops"
Updated by Renato Botelho almost 5 years ago
- Status changed from Pull Request Review to Feedback
PR has been merged. Thanks!
Updated by Viktor Gurov almost 5 years ago
- Status changed from Feedback to Resolved
arpwatch 0.2.0_3 - OK