Project

General

Profile

Actions

Bug #10527

closed

L2TP shared secret is ignored

Added by Viktor Gurov almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
L2TP
Target version:
Start date:
05/05/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5
Affected Architecture:

Description

Shared secret on vpn_l2tp.php page is never used,
I don't see any code that uses it, and there is no "set l2tp secret" entry in mpd.conf

http://mpd.sourceforge.net/doc5/mpd48.html#48:

set l2tp secret secret
 Sets the L2TP tunnel secret. Used to authenticate tunnel connection and encrypt important control packets avpairs. For server side, 
 only one unique secret supported for every pair of listening IP (set l2tp self ...) and peer ip (set l2tp peer ...). If several 
 secrets defined, only the first matching will be used for all incoming connections.

 NOTE: This options is not related with usual PPP authentication. Windows client does not support tunnel authentication.

Actions #2

Updated by Renato Botelho almost 4 years ago

  • Status changed from New to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.4.5-p1

PR has been merged. Thanks!

Actions #3

Updated by Jim Pingle almost 4 years ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Renato Botelho to Jim Pingle

This doesn't work. The secret has base64_decode run on it, but the secret was not stored with base64 encoding, so the config contains invalid data.

Actions #4

Updated by Jim Pingle almost 4 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Jim Pingle almost 4 years ago

  • Status changed from Feedback to Resolved

Working correctly now after a gitsync.

Actions

Also available in: Atom PDF