Project

General

Profile

Actions

Feature #10665

closed

Manual OSPF neighbor definitions

Added by Jim Pingle almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
FRR
Target version:
-
Start date:
06/15/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:

Description

OSPF interface modes "non-broadcast" and "point-to-miltipoint" rely on being able to manually define specific OSPF neighbors, but the FRR GUI does not currently have this ability.

Add support for this to the FRR GUI, either on its own tab under OSPF or a rowhelper somewhere since there are so few options (neighbor IP address, and optional poll interval and priority)

pfsense# conf t
pfsense(config)# router ospf
pfsense(config-router)# neighbor ?
  A.B.C.D  Neighbor IP address
pfsense(config-router)# neighbor 10.3.0.222 ?
  <cr>
  poll-interval  Dead Neighbor Polling interval
  priority       Neighbor Priority
pfsense(config-router)# neighbor 10.3.0.222 poll-interval ?
  (1-65535)  Seconds
pfsense(config-router)# neighbor 10.3.0.222 priority ?
  (0-255)  Priority

This setting doesn't appear to be in OSPF6, so only OSPF needs changed at the moment.


Files

Error_when_you_open_Neighbors_menu.png (9.94 KB) Error_when_you_open_Neighbors_menu.png Azamat Khakimyanov, 09/21/2020 06:40 AM
FRR_OSPF_menu_with_Neighbors.png (13.5 KB) FRR_OSPF_menu_with_Neighbors.png Azamat Khakimyanov, 09/21/2020 06:40 AM
Active_Neighbors_menu.png (41.8 KB) Active_Neighbors_menu.png Azamat Khakimyanov, 09/21/2020 06:54 AM
Actions #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
Actions #3

Updated by Renato Botelho over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #4

Updated by Azamat Khakimyanov over 3 years ago

Tested on:
2.5.0-DEVELOPMENT (amd64)
built on Mon Sep 21 01:04:35 EDT 2020
FreeBSD 12.2-PRERELEASE

I didn't find any new features which allows to define OSPF neighbors when Interface mode is "non-broadcast" or "point-to-miltipoint".
When I tried to use path: pkg.php?xml=frr/frr_ospf_neighbors.xml I got error:
"Package path /usr/local/pkg//frr/frr_ospf_neighbors.xml not found.
Try reinstalling the package."

So I reinstalled FRR package. After that I saw "Neighbors" menu in FRR OSPF (attached file "FRR_OSPF_menu_with_Neighbors.png") but when I tried to open it I got the same error:
"Package path /usr/local/pkg//frr/frr_ospf_neighbors.xml not found.
Try reinstalling the package."
(attached file "Error_when_you_open_Neighbors_menu.png")
And there was no "frr_ospf_neighbors.xml" file in /usr/local/pkg/frr/ folder.

So I created 'frr_ospf_neighbors.xml' and added content according to this guide: https://github.com/pfsense/FreeBSD-ports/pull/916/commits/d320a5951cd35c86cefcd85b981a47ab1ab13024
and rebooted pfSense. After reboot I see now active "Neighbors" menu and I can add neighbors (attached file "Active_Neighbors_menu.png")

Ticket was not resolved, "Neighbors" menu was added but "frr_ospf_neighbors.xml" file was not created.

Actions #5

Updated by Jim Pingle over 3 years ago

Looks like it's missing entries in pkg-plist and Makefile to install that file.

Actions #6

Updated by Jim Pingle over 3 years ago

  • Status changed from Assigned to Feedback

I committed fixes which should fix this. Will be available shortly.

Actions #7

Updated by Azamat Khakimyanov over 3 years ago

Tested on:
2.5.0-DEVELOPMENT (amd64)
built on Tue Sep 29 01:01:39 EDT 2020
FreeBSD 12.2-PRERELEASE

Issue with absence of 'frr_ospf_neighbors.xml' file is fixed now.

But I wasn't able to get working setup with 'Non-broadcast' on both Hub and Spoke (both were 2.5.0-DEV).
I created:
HUB
- Router Priority 255:
- WAN (192.168.122.78) area 0 (NBMA)
- LAN (192.168.78.1) area 0 (Passive)
- 'Redistribute a Default route to neighbors' checked
- Neighbor: 192.168.122.53 (Neighbor Priority: 0)

Spoke
- Router Priority 0:
- WAN (192.168.122.53) area 0 (NBMA)
- LAN (192.168.53.1) area 0 (Passive)
- Neighbor: 192.168.122.78 (Neighbor Priority: 255)

On both Hub and Spoke 'show ip ospf neighbor' were empty.

On HUB: show ip ospf interface
vtnet0 is up
ifindex 1, MTU 1500 bytes, BW 10000 Mbit
Internet Address 192.168.122.78/24, Broadcast 192.168.122.255, Area 0.0.0.0
MTU mismatch detection: enabled
Router ID 192.168.122.78, Network Type NBMA, Cost: 10
Transmit Delay is 1 sec, State DR, Priority 255
No backup designated router on this network
Multicast group memberships: OSPFAllRouters
Timer intervals configured, Hello 30s, Dead 120s, Wait 120s, Retransmit 5
Hello due in 9.160s
Neighbor Count is 0, Adjacent neighbor count is 0
BFD: Detect Multiplier: 3, Min Rx interval: 300, Min Tx interval: 300

On Spoke: show ip ospf interface
vtnet0 is up
ifindex 1, MTU 1500 bytes, BW 10000 Mbit
Internet Address 192.168.122.53/24, Broadcast 192.168.122.255, Area 0.0.0.0
MTU mismatch detection: enabled
Router ID 192.168.122.53, Network Type NBMA, Cost: 10
Transmit Delay is 1 sec, State DROther, Priority 0
No backup designated router on this network
Multicast group memberships: OSPFAllRouters
Timer intervals configured, Hello 30s, Dead 120s, Wait 120s, Retransmit 5
Hello due in 8.935s
Neighbor Count is 0, Adjacent neighbor count is 0
BFD: Detect Multiplier: 3, Min Rx interval: 300, Min Tx interval: 300

so Hub is DR when Spoke is DRother but Neighbor counts are zero on both. So even when we added neighbors manually FRR/OSPF doesn't see it.

I got working setup with 'Point-to-multipoint' on Hub and 'Point-to-point' on Spoke - no problem (the same settings as I tried for NBMA, just changed Network type)

Actions #8

Updated by Azamat Khakimyanov over 3 years ago

  • Status changed from Feedback to Assigned
Actions #9

Updated by Jim Pingle over 3 years ago

  • Status changed from Assigned to Feedback

There was an issue introduced recently which was not including the neighbor settings in the FRR configuration, I pushed a fix for it now.

It works for me when set to 'non-broadcast' mode.

Actions #10

Updated by Azamat Khakimyanov over 3 years ago

  • Status changed from Feedback to Resolved

Retested on 2.5-DEVELOPMENT (built on Thu Jan 07 21:49:58 EST 2021)

'Non-broadcast' mode works for me too now.

This feature request can be marked Resolved.

Actions

Also available in: Atom PDF