Project

General

Profile

Actions

Bug #10835

closed

Verification on the interface group name length is not correct

Added by Théo Sarrazin about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Category:
Interfaces
Target version:
Start date:
08/14/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:
All

Description

ifconfig take group name with less than 15 characters, but in the file interfaces_groups_edit.php, we can find the following line:

if (strlen($_POST['ifname']) > 16) {

which is incorrect, so if, in the interface, we put a name with 16 characters, pfsense would be OK, while ifconfig is call with a wrong name length and it will not take effect.

Actions #1

Updated by Jim Pingle about 1 year ago

  • Target version set to 2.5.0
Actions #2

Updated by Théo Sarrazin about 1 year ago

Change maxlenght of interface group name:
https://github.com/pfsense/pfsense/pull/4423

Actions #3

Updated by Jim Pingle about 1 year ago

  • Status changed from New to Pull Request Review
Actions #4

Updated by Renato Botelho about 1 year ago

  • Status changed from Pull Request Review to Feedback
  • Assignee changed from Théo Sarrazin to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Danilo Zrenjanin about 1 year ago

  • Status changed from Feedback to Resolved

Tested on :

2.5.0-DEVELOPMENT (amd64)
built on Wed Sep 09 19:46:45 EDT 2020
FreeBSD 12.2-PRERELEASE

It allows only 15 characters now.

Ticket resloved.

Actions

Also available in: Atom PDF