Project

General

Profile

Bug #10892

Large number of VLAN/LANs make floating rules are to read

Added by Joe Slent about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
09/12/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.5-p1
Affected Architecture:
All

Description

Since the following commit for 2.4.5, the interface column was introduced for floating rules: https://redmine.pfsense.org/projects/pfsense/repository/revisions/bf83fb9ab93435e605d28b67e0352d32ce63ba2d/diff/src/usr/local/www/firewall_rules.php

However this has dramatically decreased the usability of the WebGUI when analyzing floating rules in case of many interfaces being assigned to the rules due to the way they are listed:

echo implode('<br/>', $selected_descs);

I.e. If I assign a couple of rules to 10 interfaces each, I have eaten away my whole screen estate.

This issue is to enhance that, and we could do it in a couple of ways:
1. very easily, change the implode to comma separate the list, instead of using <br>, e.g. implode(', ', $selected_descs); This is my favourite. It compresses the raws without decreasing readability and it's a very safe change to make.
2. keep the <br>, but hide if more than 1 lines. Example https://css-tricks.com/almanac/properties/l/line-clamp/ (this should retain the page text-searchable).
3. any other css/display things with some link to show/hide

floating-rules.png (84.1 KB) floating-rules.png Example of 3 rules in floating with many interfaces assigned Joe Slent, 09/12/2020 03:04 AM
10892rules.png (5.77 KB) 10892rules.png Max Leighton, 09/20/2020 04:03 PM

Associated revisions

Revision 03c0fd1e (diff)
Added by Viktor Gurov about 2 months ago

Floating rules with large number of interfaces fix. Issue #10892

History

#2 Updated by Joe Slent about 2 months ago

Note there is a typo in the title -- meant to write "hard to read".

#4 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#5 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#6 Updated by Max Leighton about 1 month ago

Tested in

2.5.0-DEVELOPMENT (amd64)
built on Sun Sep 20 06:59:15 EDT 2020
FreeBSD 12.2-PRERELEASE

and patch in

2.4.5-RELEASE-p1 (amd64)
built on Tue Jun 02 17:51:17 EDT 2020
FreeBSD 11.3-STABLE

Interfaces now appear as a comma separated imploded list as expected. Marking the ticket resolved.

Also available in: Atom PDF