Project

General

Profile

Bug #10982

Primary/Secondary DNS Server field validation issue in Setup Wizard

Added by Jared Dillard 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Jared Dillard
Category:
Web Interface
Target version:
Start date:
10/15/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
Release Notes:
Default

Description

When clearing out the Primary/Secondary DNS Server fields in the Setup Wizard it causes the validation to fail. An empty field might need to be considered valid to prevent that.

Associated revisions

Revision d4dc6562 (diff)
Added by Steve Beaver 6 months ago

Fixed #10982 by adjusting validation regex.

History

#1 Updated by Steve Beaver 6 months ago

  • Target version set to 2.5.0
  • Affected Version set to All

Adjusted regex to permit secondary DNS server setting to be blank

#2 Updated by Steve Beaver 6 months ago

  • Status changed from New to Feedback
  • Priority changed from Normal to Low

#3 Updated by Steve Beaver 6 months ago

  • Assignee changed from Steve Beaver to Jared Dillard

#4 Updated by Steve Beaver 6 months ago

  • % Done changed from 0 to 100

#5 Updated by Max Leighton 6 months ago

When I run through the setup wizard with Allow DNS servers to be overridden by DHCP/PPP on WAN unchecked in

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 18 07:01:13 EDT 2020
FreeBSD 12.2-STABLE

it will accept blank fields for the primary server, secondary server, or both. Validation still fails as expected for invalid addresses like test, 0, 256.256.256.256, etc.

Unless we want to require at least one valid server here, this can be marked as resolved.

#6 Updated by Jim Pingle 6 months ago

  • Status changed from Feedback to Resolved

The default config (With DNS Resolver enabled and in Resolver mode) does not require any DNS servers to be present under System > General or in the wizard. So accepting blank DNS servers is not only allowed, it is the most desirable behavior.

In the future we may want to add a checkbox to the wizard to allow the user to choose forwarding mode here, but that's unrelated to this as it is now.

Also available in: Atom PDF