Bug #10982
closed
Primary/Secondary DNS Server field validation issue in Setup Wizard
100%
Description
When clearing out the Primary/Secondary DNS Server fields in the Setup Wizard it causes the validation to fail. An empty field might need to be considered valid to prevent that.
Updated by Anonymous about 4 years ago
- Target version set to 2.5.0
- Affected Version set to All
Adjusted regex to permit secondary DNS server setting to be blank
Updated by Anonymous about 4 years ago
- Status changed from New to Feedback
- Priority changed from Normal to Low
Updated by Anonymous about 4 years ago
- Assignee changed from Anonymous to Jared Dillard
Updated by Anonymous about 4 years ago
- % Done changed from 0 to 100
Applied in changeset d4dc6562bf1eb5948bdc34ad09478c810df968eb.
Updated by Max Leighton about 4 years ago
When I run through the setup wizard with Allow DNS servers to be overridden by DHCP/PPP on WAN unchecked in
2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 18 07:01:13 EDT 2020
FreeBSD 12.2-STABLE
it will accept blank fields for the primary server, secondary server, or both. Validation still fails as expected for invalid addresses like test, 0, 256.256.256.256, etc.
Unless we want to require at least one valid server here, this can be marked as resolved.
Updated by Jim Pingle about 4 years ago
- Status changed from Feedback to Resolved
The default config (With DNS Resolver enabled and in Resolver mode) does not require any DNS servers to be present under System > General or in the wizard. So accepting blank DNS servers is not only allowed, it is the most desirable behavior.
In the future we may want to add a checkbox to the wizard to allow the user to choose forwarding mode here, but that's unrelated to this as it is now.