Project

General

Profile

Actions

Bug #11360

closed

captive portal custom logo error

Added by Viktor Gurov 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Captive Portal
Target version:
Start date:
02/02/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.5.0
Affected Architecture:

Description

https://forum.netgate.com/topic/160450/crash-report:
It crashed abruptly when trying to configure captive portal. Also the logo and background files keep missing in the config page (very minor issue) but can still see in the captive portal login page.

PHP Errors:
[02-Feb-2021 10:15:21 Asia/Singapore] PHP Warning:  Invalid argument supplied for foreach() in /etc/inc/captiveportal.inc on line 58
[02-Feb-2021 10:15:21 Asia/Singapore] PHP Warning:  Invalid argument supplied for foreach() in /etc/inc/captiveportal.inc on line 69
[02-Feb-2021 10:15:21 Asia/Singapore] PHP Warning:  Invalid argument supplied for foreach() in /etc/inc/captiveportal.inc on line 58
[02-Feb-2021 10:15:21 Asia/Singapore] PHP Warning:  Invalid argument supplied for foreach() in /etc/inc/captiveportal.inc on line 69
[02-Feb-2021 10:17:52 Asia/Singapore] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /usr/local/www/services_captiveportal.php on line 441
[02-Feb-2021 10:19:31 Asia/Singapore] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /usr/local/www/services_captiveportal.php on line 441

Actions #1

Updated by Steve Wheeler 9 months ago

To be clear this is triggered when enabling the custom logo option and then not uploading a file. Or by not also uploading a background image.

Actions #3

Updated by Jim Pingle 9 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions #4

Updated by Steve Wheeler 9 months ago

Tested that patch against:

2.5.0-DEVELOPMENT (amd64)
built on Tue Feb 02 00:05:06 EST 2021
FreeBSD 12.2-STABLE

Looks good with that, I cannot trigger any errors.

The fact a logo/background file present is not indicated which is inconvenient, it's hard to test the first part of this. Just cosmetic though.

Actions #5

Updated by Renato Botelho 9 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

Actions #6

Updated by Viktor Gurov 9 months ago

  • Status changed from Feedback to Resolved

2.5.0.a.20210202.2250 fixed

Actions

Also available in: Atom PDF