Bug #11552
closed
Incorrect phase 2 entry removed when deleting multiple items consecutively
100%
Description
I had a phase1 entry with 6 phase2 entries. 3 of the phase2 entries were for tunnels to LAN and the other 3 were for tunnels to OPT1.
We no longer required the tunnels to OPT1 so I went to delete them by going to VPN - IPSec + Show Pase 2 Entries.
The P2 entries were listed as follows:
Mode Local Subnet Remote Subnet
tunnel LAN 10.0.0.0/24
tunnel OPT1 10.0.0.0/24
tunnel LAN 10.0.1.0/24
tunnel OPT1 10.0.1.0/24
tunnel LAN 10.0.2.0/24
tunnel OPT1 10.0.2.0/24
I clicked on the delete button for the first OPT1 and clicked OK to the confirmation. The screen reloads with the first OPT1 now missing as you would expect.
Mode Local Subnet Remote Subnet
tunnel LAN 10.0.0.0/24
tunnel LAN 10.0.1.0/24
tunnel OPT1 10.0.1.0/24
tunnel LAN 10.0.2.0/24
tunnel OPT1 10.0.2.0/24
I then clicked on the delete button for the next OPT1 and click OK to the confirmation. The screen reloads with one of the LAN P2s missing.
Mode Local Subnet Remote Subnet
tunnel LAN 10.0.0.0/24
tunnel OPT1 10.0.1.0/24
tunnel LAN 10.0.2.0/24
tunnel OPT1 10.0.2.0/24
I have tested on 2.4.5-p1 and 2.5.0, both are affected.
Updated by Jim Pingle 8 months ago
- Category changed from Web Interface to IPsec
- Status changed from New to Confirmed
- Target version set to CE-Next
Confirmed here.
Test 1:
Made 6 P2 entries: 0 1 2 3 4 5
Deleted "1" P2: 0 2 3 4 5
Deleted "3" P2: 0 2 3 5
Test 2:
Made 6 P2 entries: 0 1 2 3 4 5
Deleted "1" P2: 0 2 3 4 5
Refreshed the page manually
Deleted "3" P2: 0 2 4 5
So it's something about staying on the page after the first delete, it must not be reindexing the entries after the removal.
Updated by Jim Pingle 3 months ago
- Status changed from Confirmed to In Progress
- Assignee set to Jim Pingle
Updated by Jim Pingle 3 months ago
- Subject changed from IPSec VPN Web Interface - Incorrect phase 2 entry being deleted on second delete to Incorrect phase 2 entry removed when deleting multiple items consecutively
- Target version changed from CE-Next to 2.6.0
- Plus Target Version set to 21.09
Updating subject for release notes.
Updated by Jim Pingle 3 months ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
Applied in changeset bec6dcfbbef4832b34d47ca60b0671b23dc185d8.
Updated by Max Leighton 3 months ago
Tested in
2.6.0-DEVELOPMENT (amd64)
built on Sat Jul 31 01:15:09 EDT 2021
FreeBSD 12.2-STABLE
Repeating Jim's test I saw the following:
Made 6 P2 entries: 0 1 2 3 4 5
Deleted "1" P2: 0 2 3 4 5
Deleted "3" P2: 0 2 4 5
So that worked as expected.