Project

General

Profile

Actions
Copy link

Bug #11552

closed

Incorrect phase 2 entry removed when deleting multiple items consecutively

Added by Dave Roberts over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
IPsec
Target version:
2.6.0
Start date:
02/26/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

I had a phase1 entry with 6 phase2 entries. 3 of the phase2 entries were for tunnels to LAN and the other 3 were for tunnels to OPT1.

We no longer required the tunnels to OPT1 so I went to delete them by going to VPN - IPSec + Show Pase 2 Entries.
The P2 entries were listed as follows:
Mode Local Subnet Remote Subnet
tunnel LAN 10.0.0.0/24
tunnel OPT1 10.0.0.0/24
tunnel LAN 10.0.1.0/24
tunnel OPT1 10.0.1.0/24
tunnel LAN 10.0.2.0/24
tunnel OPT1 10.0.2.0/24

I clicked on the delete button for the first OPT1 and clicked OK to the confirmation. The screen reloads with the first OPT1 now missing as you would expect.

Mode Local Subnet Remote Subnet
tunnel LAN 10.0.0.0/24
tunnel LAN 10.0.1.0/24
tunnel OPT1 10.0.1.0/24
tunnel LAN 10.0.2.0/24
tunnel OPT1 10.0.2.0/24

I then clicked on the delete button for the next OPT1 and click OK to the confirmation. The screen reloads with one of the LAN P2s missing.

Mode Local Subnet Remote Subnet
tunnel LAN 10.0.0.0/24
tunnel OPT1 10.0.1.0/24
tunnel LAN 10.0.2.0/24
tunnel OPT1 10.0.2.0/24

I have tested on 2.4.5-p1 and 2.5.0, both are affected.

Actions
Copy link
 #1

Updated by Jim Pingle over 3 years ago

  • Category changed from Web Interface to IPsec
  • Status changed from New to Confirmed
  • Target version set to CE-Next

Confirmed here.

Test 1:

Made 6 P2 entries: 0 1 2 3 4 5
Deleted "1" P2: 0 2 3 4 5
Deleted "3" P2: 0 2 3 5

Test 2:

Made 6 P2 entries: 0 1 2 3 4 5
Deleted "1" P2: 0 2 3 4 5
Refreshed the page manually
Deleted "3" P2: 0 2 4 5

So it's something about staying on the page after the first delete, it must not be reindexing the entries after the removal.

Actions
Copy link
 #2

Updated by Jim Pingle over 3 years ago

  • Status changed from Confirmed to In Progress
  • Assignee set to Jim Pingle
Actions
Copy link
 #3

Updated by Jim Pingle over 3 years ago

  • Subject changed from IPSec VPN Web Interface - Incorrect phase 2 entry being deleted on second delete to Incorrect phase 2 entry removed when deleting multiple items consecutively
  • Target version changed from CE-Next to 2.6.0
  • Plus Target Version set to 21.09

Updating subject for release notes.

Actions
Copy link
 #4

Updated by Jim Pingle over 3 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Max Leighton over 3 years ago

Tested in

2.6.0-DEVELOPMENT (amd64)
built on Sat Jul 31 01:15:09 EDT 2021
FreeBSD 12.2-STABLE

Repeating Jim's test I saw the following:

Made 6 P2 entries: 0 1 2 3 4 5
Deleted "1" P2: 0 2 3 4 5
Deleted "3" P2: 0 2 4 5

So that worked as expected.

Actions
Copy link
 #6

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #7

Updated by Jim Pingle about 3 years ago

  • Plus Target Version changed from 21.09 to 22.01
Actions
Copy link

Also available in: Atom PDF