Project

General

Profile

Bug #11762

Invalid combinations of TCP flag matching options cause ``pfctl`` parser error

Added by Viktor Gurov about 1 month ago. Updated 2 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Category:
Rules / NAT
Target version:
Start date:
03/31/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
21.05
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:

Description

There were error(s) loading the rules: /tmp/rules.debug:170: flags always false - 
The line in question reads [170]: 
pass in quick on $SYNC inet proto tcp from 7.7.7.7 to any tracker 1617182080 flags SAUEW/P keep state label "USER_RULE: testflags"
@ 2021-03-31 15:02:16

input validation must check TCP flags for condition:
https://github.com/pfsense/FreeBSD-src/blob/da3fcfc9b768892ebf17aa92bd10761e2c76a72d/sbin/pfctl/parse.y#L891

Associated revisions

Revision 6a6b7b0b (diff)
Added by Viktor Gurov 3 days ago

Firewall Rule TCP flags input validation. Fixes #11762

History

#1 Updated by Jim Pingle about 1 month ago

  • Subject changed from pfctl parser error if TCP 'out of' flags < TCP 'set' flags to Invalid combinations of TCP flag matching options cause ``pfctl`` parser error
  • Target version set to CE-Next

Updating subject for release notes

#3 Updated by Jim Pingle about 1 month ago

  • Status changed from New to Pull Request Review

#4 Updated by Viktor Gurov 3 days ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

#5 Updated by Jim Pingle 2 days ago

  • Target version changed from CE-Next to 2.6.0

#6 Updated by Jim Pingle 2 days ago

  • Plus Target Version set to 21.05

#7 Updated by Jim Pingle 2 days ago

Already in 21.05 branch.

Also available in: Atom PDF